Thoughts about the repo's name about docker-pm2 HOT 30 CLOSED

+1 for docker-pm2

from docker-pm2.

Another problem is that currently the binary is called pm2-docker. We should also rename the binary into the pm2 repo:
https://github.com/Unitech/pm2/search?utf8=%E2%9C%93&q=pm2-docker

from docker-pm2.

@simonepri I don't think it's that much a problem, there is a difference between the binary name and the image name

from docker-pm2.

Awesome! Should we export all the tags from the official node repo also?

• deprecation notice https://hub.docker.com/r/keymetrics/pm2-docker-alpine/
• on new pm2 release, trigger auto build

Also I've built something that may interest you: Unitech/pm2#3094 feedbacks welcome!

from docker-pm2.

Also we should look how to mark that image as official.
PM2 is quite huge project, I think that the Docker team will publish it without any particular concern.
https://docs.docker.com/docker-hub/official_repos/

from docker-pm2.

A rewording make sense. What do you mean by adding support for more docker images?

from docker-pm2.

Github should handle the url redirect automagically, but i'm not sure about that.
Maybe a new repo is better, but I think it can generate confusion.

from docker-pm2.

The official nodeJS Docker repo ships more than just alpine's node images.
https://hub.docker.com/r/library/node/tags/

from docker-pm2.

Maybe we can create a script that pulls automatically all tags from the Official nodeJS docker repo and generates all Dockerfile for this repo.

from docker-pm2.

This could be the first step, and then we will think about implications of the rewording.

from docker-pm2.

Alright I see, thanks. Building that script would be a great idea, let me know if you need any help on that.
I confirm that github handle well redirection when renaming a repo, anyway I will impact this change on the docker registry

from docker-pm2.

pm2-docker or docker-pm2 ??
The official node repo is called:
docker-node

I'll try to do the script and then I'll open a PR 🚀

from docker-pm2.

Let's go for docker-pm2!

from docker-pm2.

Hello @simonepri!
So what should we do about the repo name on the docker registry? Do we rename pm2-docker-alpine to docker-pm2 or I create a second container image named docker-pm2?

from docker-pm2.

I think the best way is to keep pm2-docker-alpine, since we cannot break users' images.
Then we can create a new image named just pm2 as you suggested.

I want to see if it's possible to start a build on Docker Hub each time the node image on Docker Hub ends a build process.
Now if the node image is updated our latest image doesn't gets the update until we manually rebuild it.

from docker-pm2.

I thought we would create a new image called docker-pm2, but pm2 as an image name would be nice also, why not.
Looking forward this script, that would be great to auto build this container based on the node image

from docker-pm2.

@simonepri what do you think of https://hub.docker.com/r/keymetrics/docker-pm2/? It's a replicat of pm2-docker-alpine but at least it has the right name

from docker-pm2.

It makes sense. Why did you choose docker-pm2 instead of just pm2?
Sorry for the delay but I was full of work. I will try to improve the image asap.

from docker-pm2.

let's keep it short https://hub.docker.com/r/keymetrics/pm2/

from docker-pm2.

Perfect!
May I ask you to add me as collaborator on the hub?

I want to see if its possible to use this:
https://docs.docker.com/docker-hub/builds/#repository-links

It seems that is possible to start a build process when another Docker image has been build.
This will solve our sync problem with the official nodejs image.

from docker-pm2.

that sounds good, I've just added you as a collaborator

from docker-pm2.

Thanks @Unitech but I can't see any difference:

from docker-pm2.

I've double checked, you've been added to the repo:

from docker-pm2.

It seems that on the Docker Hub a Collaborator is just someone that can see the image also if that is set as private:
https://docs.docker.com/docker-hub/repos/#collaborators-and-their-role

from docker-pm2.

I've followed this tutorial to turn keymetrics into an organization and I've added you as owner :)

from docker-pm2.

@Unitech thanks.
Those are the things we have to do:

• Link the node's repo to the pm2's repo on the Docker Hub.
  This will trigger the build of pm2's images each time node's images are built.
• Create a trigger in the build settings of the pm2's repo on the Docker Hub.
  This will generates a link that when POSTed will trigger the build of pm2's images.
• Add the trigger's URL in the Web Hooks of the pm2's repo on npm.
  Each time a new version of pm2 is released on npm our pm2 repo on Docker Hub will be rebuilt.

More info about the last step can be found here:
http://blog.npmjs.org/post/145260155635/introducing-hooks-get-notifications-of-npm

from docker-pm2.

Hooks on npm seems to be a paid feature.

• Instead we can add the trigger directly in the Web Hooks section of pm2's GitHub repo.

from docker-pm2.

@Unitech I've censored the image since the trigger token shouldn't be public available.
Anyway it looks perfect now. 🎉

For the others images the idea was to export all tags with node >= 4

• latest, alpine, onbuild, slim, stretch, wheezy <- These fetches always the latest release
• 8, 8-alpine, 8-onbuild, 8-slim, 8-stretch, 8-wheezy
• 7, 7-alpine, 7-onbuild, 7-slim, 7-stretch, 7-wheezy <- Should we support non LTS versions???
• 6, 6-alpine, 6-onbuild, 6-slim, 6-stretch, 6-wheezy
• 4, 4-alpine, 4-onbuild, 4-slim, 4-stretch, 4-wheezy

from docker-pm2.

I've replaced all occurences of pm2-docker-alpine to pm2
To export all tags, do we need to create a folder for each tag?

from docker-pm2.

@simonepri Node 7 has been dropped of the official node image repo, also pm2 doesn't support node 7 since it isnt a LTS. We should not build image on it i think

from docker-pm2.