Git Product home page Git Product logo

Comments (8)

mposolda avatar mposolda commented on June 29, 2024 1

Closing as it is fixed already. (@vmuzikar The issues are not automatically closed when merged PR, which is likely something to fix at GH actions).

from keycloak-quickstarts.

vmuzikar avatar vmuzikar commented on June 29, 2024

We should probably update the quickstart so it doesn't include the $$VERSION$$ placeholder at all in the latest branch.

from keycloak-quickstarts.

bnallapeta avatar bnallapeta commented on June 29, 2024

@vmuzikar What should we replace $$VERSION$$ with? If we simply use the current latest version (21.0.5), we would need to constantly update this file with each new release.

from keycloak-quickstarts.

bnallapeta avatar bnallapeta commented on June 29, 2024

I don't see any release specific Github workflow to automate this too. If that was part of the setup, we probably could have added a step to auto-update the version with each release.

from keycloak-quickstarts.

vmuzikar avatar vmuzikar commented on June 29, 2024

The latest branch is updated automatically (e.g. versions in POMs) with each new release. And looks like we're already setting the version in yamls too, set-version.sh which is called during the release process.

Not sure what's happening there, we need to investigate.

from keycloak-quickstarts.

bnallapeta avatar bnallapeta commented on June 29, 2024

@vmuzikar I think its probably because of the lack of escape character? In the PR I had submitted, I have used the escape character for $ and it works. Should I raise a PR with that change?

from keycloak-quickstarts.

vmuzikar avatar vmuzikar commented on June 29, 2024

@bnallapeta Possibly yes, but I haven't had time yet to investigate deeper. A PR would be most welcome! :)

from keycloak-quickstarts.

bnallapeta avatar bnallapeta commented on June 29, 2024

@vmuzikar #504

from keycloak-quickstarts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.