Memory leak when `keybase status` times out about go-keybase-chat-bot HOT 6 CLOSED

@vladionescu thanks for the report, we have a ticket internally to investigate this

from go-keybase-chat-bot.

@vladionescu #57 should address the memory leak, let's open a new issue for running on google cloud

from go-keybase-chat-bot.

Adding time keybase status to the entrypoint shell script right before my bot gets executed shows that it returns kinda slowly but still faster than 5 seconds. The 'failed to auth' error persists. Why this is happening is likely a separate issue but I wanted to have this context here.

2020-02-21T01:59:47.814485Z real	0m1.311s A 
2020-02-21T01:59:47.814497Z user	0m0.150s A 
2020-02-21T01:59:47.814509Z sys	0m0.080s A 

from go-keybase-chat-bot.

@malware-unicorn fixed the OOM by adding a <-doneCh in the timeout case:
https://github.com/malware-unicorn/go-keybase-chat-bot/blob/master/kbchat/kbchat.go#L64

from go-keybase-chat-bot.

On another note, I suspect the reason Command("status") fails on Cloud Run is because Cloud Run captures STDOUT and STDERR for logging.

https://cloud.google.com/run/docs/logging#container-logs

They probably neglected to duplicate those file descriptors. @malware-unicorn doesn't see this fmt.Errorf() printed, so something's going on with process output.

https://github.com/malware-unicorn/go-keybase-chat-bot/blob/master/kbchat/kbchat.go#L65

If that's the case, then p.StdoutPipe() wouldn't be getting the expected output from status.

The fix for this is either

1. Send Command() output to an FD we control, and read from that.
2. Use an API instead of shelling out to the keybase binary.

from go-keybase-chat-bot.

Opened #58 for the Cloud Run shenanigans.

from go-keybase-chat-bot.