Git Product home page Git Product logo

Comments (3)

KevinBatdorf avatar KevinBatdorf commented on May 16, 2024

Hey Brian,

I think you are confusing Eric Meyer's reset for the HTML5 Boilerplate? I included the reset because I began to receive complaints that the slider was inheriting too much from other elements. Most users are not CSS gurus and do not understand their own code. They then assume the slider is broken. This was a 2kb compromise that improved the experience for many. Additionally, it only resets elements within the coda-slider. So it won't affect the rest of your code in any way. If you'd like, you can even delete that section. It's not dependent on anything.

The SASS file is optional. You can delete it at your convenience too and it won't change a thing. Additionally, I kept it very, very basic. If you wanted to make it a LESS file, I believe you would only have to change the suffix to '.less'. The only feature I used is nesting, which uses the same syntax in both pre-processors, right? However, future versions will include variables, and perhaps some other basic stuff. Again, all pre-processors are optional and can be deleted without issue.

You're the first person to have an issue with the SASS file (I actually assume most don't even pay attention to it). I could easily include a LESS file as well in future versions, especially since variables are just $sass vs. @less. I wanted to include at least one or the other though, as I believe pre-processors are great, and SASS seems to be more popular lately. I'll put some thought into it.

Let me know if you need anything else.

from codaslider.

brianfeister avatar brianfeister commented on May 16, 2024

I totally hear where you're coming from and you're right, looks like Eric Meyer reset on second look. For me, my original point still stands. I know there are people out there that are not great developers who don't realize they need to be using a CSS reset, but despite that fact, I would think that a reset included inside of a plugin would be outside the scope of what it should handle and creates dependencies that are asking for conflict with the environments where the plugin is installed and used.

I'm totally fine with SASS over LESS, I just want to see a cleaner, more modular CSS file that follows Twitter Bootstrap & Jonathan Snook's http://smacss.com architecture for modular CSS. I always thought this was the default for plugins (and the community is just now "getting it" with regard to entire site-wide CSS architecture).

from codaslider.

KevinBatdorf avatar KevinBatdorf commented on May 16, 2024

I'll consider removing it again and see if I hear more complaints about it not working properly. BUT, it's a local reset meaning that if only affects elements within the .coda-slider-wrapper { }. It's not a site wide reset. It wont affect your margins outside of the slider. There are no dependencies nor conflicts with anything else. Additionally, it's not a complete reset as I took out a few elements that were not relevant (I noticed I left in body though, which was by accident and is useless).

The only argument I can see is that it adds 2kb that isn't needed for the majority of users (it's there for the newbs). I'll probably remove it and see what happens.

As for the organization of the CSS.... meh. It's not something I really feel is important. It's not a standard practice as far as I know. I think that separating it into a "You can edit these" and a "don't mess with this" section keeps new users from messing everything up. This is how it was when I took over the slider, and I like it.

I've actually considered removing the SASS file though all together just to keep it simple for everyone. I'll try to clean up the entire CSS file for the next version. I'm undecided at this point.

from codaslider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.