Git Product home page Git Product logo

Comments (1)

kettek avatar kettek commented on September 7, 2024 1

It would seem some bundlers don't respect the use of remote.require per-default. This line exists solely to ensure that the main process has required the electron-app-settings module so that settings can be reliably saved from the renderer process. If the main process has already required the module(as you noticed), then this line does nothing. As such, this does not qualify as a bug, but rather as a problem in the domain of webpack.

However, it would be nice to be able to conditionally disable the remote.require line. I could add an environment variable check to disable the use of remote.require, with the caveat that the end-user would have to ensure that environment variable is set (via the invoking shell or through webpack's DefinePlugin). Perhaps via an environment variable such as NO_REMOTE_REQUIRE?

from electron-app-settings.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.