Global task defaults not keeping the letter case about kestra HOT 10 CLOSED

https://github.com/kestra-io/kestra/blob/develop/core/src/main/java/io/kestra/core/services/TaskGlobalDefaultConfiguration.java#L11

@ConfigurationProperties(value = "kestra.tasks")
@Getter
public class TaskGlobalDefaultConfiguration {
    List<TaskDefault> defaults;
}

Is better expressed as:

@ConfigurationProperties(value = "kestra.tasks.defaults", list=true)
public class TaskDefault {
    private final String type;

    @Builder.Default
    private final boolean forced = false;

    @MapFormat(transformation = MapFormat.MapTransformation.NESTED, keyFormat = StringConvention.RAW)
    private final Map<String, Object> values;
}

Then inject List<TaskDefault>.

Also ideally git rid of Lombok 🤢🤮

from kestra.

I couldn't find any other solution than a custom TypeConverter, but seems to work

from kestra.

Hello ! After hours of digging I found an edge case in Micronaut which leads to such behaviour. I openned an issue. Meanwhile, adding at least a third UPPERCASE letter before the "_" should solve the issue (ABC_VALUE for eg.)

from kestra.

@brian-mulier-p I appreciate the effort!

from kestra.

where is the source for the configuration properties definition of this?

from kestra.

generally if you want to raw keys you need to do this https://github.com/micronaut-projects/micronaut-sql/blob/1dd793b4f4f3bf85c729a355c1773f5df3efa2fe/hibernate-jpa/src/main/java/io/micronaut/configuration/hibernate/jpa/JpaConfiguration.java#L139

from kestra.

Hello ! Thank's for the help. I think I tried that already. I can try again tomorrow to make sure but basically it looks like the MapFormat annotation isn't taken care of when it goes through such hierarchy (List with Something having a Map inside)

from kestra.

Nvm I didn't try that exact example, that's because we're mixing objects from our YAML declaration with POJO for our global configuration. It's done to create a heavy relation between those but it brings some complexity around configuring annotation. I didn't try the list=true since the lower class (TaskDefault) isn't necessarily a list :'(

from kestra.

Btw I tried your sample but list = true seems not to exist 🤔

from kestra.

Sorry it should be @EachProperty

from kestra.