push docker image fails with AWS CLI v2 about sagify HOT 4 CLOSED

Hey @gillouche , thanks for raising the issue; I haven’t upgraded to cli v2 yet, thank you for pointing out the corresponding issue on AWS’s repo.

Sounds like we’re going to have to adjust the command to accommodate for both versions if possible (presumably by checking the aws cli’s version before talking to ECR).

from sagify.

Hi,

I hit the same issue. This should work.

# Get the login command from ECR and execute it directly
if [[ ! -z "$profile" ]]; then
     aws --region ${region} ecr get-login-password --profile ${profile} | docker login --username AWS --password-stdin ${account}.dkr.ecr.${region}.amazonaws.com
else
     aws --region ${region} ecr get-login-password | docker login --username AWS --password-stdin ${account}.dkr.ecr.${region}.amazonaws.com
fi

AWS CLI v2 has been out for almost 6 months now, I'd recommend going for it :)

*** EDIT: yes, this works. I just tested it.

Started pushing Docker image to AWS ECS. It will take some time. Please, be patient...
Docker image pushed to ECS successfully!

from sagify.

Hi

this is my oneliner which works . You just need to change PROF variable value to your aws cli profile id

PROF=test-poc; $(aws ecr get-login-password --profile ${PROF} | docker login -u AWS --password-stdin $(aws sts get-caller-identity --query 'Account' --output text --profile ${PROF}).dkr.ecr.$(aws configure get region --profile ${PROF}).amazonaws.com)

from sagify.

Hey folks, @makarono @gillouche @juliensimon issue should be solved since Sagify version 0.20.8. FYI, the lastest Sagify version is 0.20.9.

from sagify.