Git Product home page Git Product logo

Comments (4)

linearza avatar linearza commented on May 30, 2024

It seems to fire the didInsertElement hook twice in each instance, not sure if its a case thats specific to our app but, a possible solution would be to check if the slider has been created before. Something like:

if (!this.get('slider')) {
  noUiSlider.create($this, properties);
}

If thats acceptable I can create a PR for it

from ember-cli-nouislider.

linearza avatar linearza commented on May 30, 2024

#31

from ember-cli-nouislider.

kennethkalmer avatar kennethkalmer commented on May 30, 2024

Hmm, didInsertElement should not run twice. I might be doing something in there that causes it to re-run and will have to have a look. Can you confirm that willDestroyElement is run in between? Maybe the cleanup is inadequate...

Thanks for the PR.

In the meanwhile, which ember versions are you using if I want to try and reproduce it.

from ember-cli-nouislider.

kennethkalmer avatar kennethkalmer commented on May 30, 2024

Closing since we have #31 & #39 tackling this. Thanks for using the addon, and reporting an issue that helps make it better for everyone!

from ember-cli-nouislider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.