Git Product home page Git Product logo

Comments (6)

kenjis avatar kenjis commented on May 24, 2024

How about this? 7e256d9

from ci-phpunit-test.

rochefort avatar rochefort commented on May 24, 2024

You are great! I should have use ob_get_level like this.
Thank you for your commit.

from ci-phpunit-test.

kenjis avatar kenjis commented on May 24, 2024

Output buffering of PHP is stackable.

Thank you for your report!

from ci-phpunit-test.

trungdq88 avatar trungdq88 commented on May 24, 2024

@kenjis I am having a same problem here, but my code is not simple as show_404 but really complicated. Do you have any advice on how to trace down the output buffering issue?

My test target method is using form_validation, ReCaptcha (third-party library) and bunch of models.

from ci-phpunit-test.

kenjis avatar kenjis commented on May 24, 2024

The reason PHPUnit reports risky is you have output buffer which is not cleared.
$this->request() calls ob_start().

You have to search ob_start() and make sure all of them are cleared and buffering is turned off.

from ci-phpunit-test.

trungdq88 avatar trungdq88 commented on May 24, 2024

@kenjis thank you, I found the reason.

There are severals call to ob_start() in core/Exceptions.php. When there is PHP Error in the application, CI render the error template and somehow mess around with the output buffering. I fixed that by fixing the error in my application code, not sure if this is a CodeIgniter's issue or should we fix it in ci-phpunit-test.

Anyway, the risky test helped me to know if there is unexpected PHP Errors in the output, so I find it helpful in an unexpected way.

from ci-phpunit-test.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.