Empty slice is not null about cl3 HOT 6 CLOSED

Thank you for raising this issue Jonas. Please can you provide an example?

from cl3.

use cl3::device::*;
let id = get_platform_ids().unwrap().pop().unwrap();

use cl3::platform::get_platform_ids;
let devs = &get_device_ids(id, CL_DEVICE_TYPE_DEFAULT) .unwrap()[..1];

use cl3::context::create_context;
use std::ptr::{null, null_mut};
let ctx = create_context(devs, null(), None, null_mut()).unwrap();

use cl3::program::*;
const SRC : &'static str = "__kernel void func(){}";
let program = create_program_with_source(ctx, &[SRC]).unwrap();

use std::ffi::CString;
let no_options = CString::new("").unwrap();
compile_program(program, devs, &no_options, &[], &[], None, null_mut()).unwrap();`

In this example, compile_program can return Err(-30), which is CL_INVALID_VALUE.
This occurs due to the two empty slices not necessarily pointing to address 0,
compile_program can return CL_INVALID_VALUE if, and I quote "num_input_headers is zero and header_include_names or input_headers are not NULL".

cl3::program::link_program also suffers from the same problem

from cl3.

I've fixed the empty slice issue in compile_program and added an assertion to ensure that the input_headers slice and header_include_names slice are the same length.

As for link_program , it doesn't make sense to call it with an empty input_programs slice, so I've added an assertion.

The changes are in the develop branch. Please let me know if there are any other issues.

from cl3.

I can see enqueue_nd_range_kernel suffers from the same problem regarding events

from cl3.

Sorry Jonas, but I can't see a problem with enqueue_nd_range_kernel events. They are just passed in as number and pointer parameters.

In the opencl crate, the events parameter is passed in as a slice, however, that code checks for an empty list like compile_program does now.

Any other issues?

from cl3.

Incorporated in version 0.6.5.

from cl3.