Describe the bug A clear and concise deion of what the bug

I have now fixed the bug. Actually, it was not a real bug, as <code class="notranslate

[bugreport]: Commands not executed when executor type PLAYER_AND_CONSOLE is set about kelp HOT 2 CLOSED

kelpframework commented on May 20, 2024

[bugreport]: Commands not executed when executor type PLAYER_AND_CONSOLE is set

from kelp.

Comments (2)

PXAV commented on May 20, 2024

Thank you for the bug report, I'll see how I can fix it!

from kelp.

PXAV commented on May 20, 2024

I have now fixed the bug. Actually, it was not a real bug, as PLAYER_AND_CONSOLE only called the onCommand(ConsoleSender, args) method and not the player method, because the command should be the same for players and consoles. But I have now changed it so that you can have both onCommand methods and depending on the executor, the corresponding method will be called.

If you want to have the same command handler method for both player and console, then you could do something like that:

@CreateCommand(name = "helloworld", executorType = ExecutorType.PLAYER_AND_CONSOLE)
public class test extends KelpCommand {

  private KelpConsoleSenderFactory senderFactory;

  @Inject
  public test(KelpConsoleSenderFactory senderFactory) {
    this.senderFactory = senderFactory;
  }

  @Override
  public void onCommandRegister() {
    allowCustomParameters(true);
  }

  @Override
  public void onCommand(KelpConsoleSender consoleSender, String[] args) {
    System.out.println("command executed by either player or console " + Arrays.toString(args));
  }

  @Override
  public void onCommand(KelpPlayer player, String[] args) {
    CommandSender sender = player.getBukkitPlayer();
    this.onCommand(senderFactory.newKelpConsoleSender(sender), args);
  }

}