Git Product home page Git Product logo

Comments (4)

kellyjonbrazil avatar kellyjonbrazil commented on August 12, 2024 1

Cool - yeah I think that sounds like a good new parser!

from jc.

georgettica avatar georgettica commented on August 12, 2024

as seen in this issue I linked to here, I found a very nice and documented repo, that makes the code work perfectely.

I don't want to just copy it and maintain myself / push the code here and I am seeing if they are ok with extracting the code to a generic section which will be in python so I can work with it in the PR.

let me know if that seems like a good idea / if you have a different approach to this / what I wrote is not reflected in the issue I created and I will correct and reconsolidate what I wrote to fit into what I want to happen

from jc.

kellyjonbrazil avatar kellyjonbrazil commented on August 12, 2024

Could work, but not sure. Since the project is coded in Golang I think you'd still need to install the Go library/dependencies before using the Python bindings, so it couldn't simply be "vendored" in like we have done with other dependencies. (see the x.509 parsers) The license seems pretty open, so that's good. This seems more like a custom parser route because even if we included a compiled version of the command and used subprocess, this would be architecture-dependent.

from jc.

georgettica avatar georgettica commented on August 12, 2024

That is great insight and I didn't even think this was an option to pull in the binary.

If the license permits, I'll try to incorporate the golang code to python (like I tried before you said but now that the license is good I can also feel better just taking this code snippet and pushing here)

I am concerned that the internal yaml implementation they have is way more stable and easy to extend than in python.

from jc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.