CronTime day of week is non-standard (Sunday is 1, not 0) about node-cron HOT 10 CLOSED

Hey,

Yes. I speak patches. :) I would like things to be consistent. Obviously both would break things so I'd upgrade the version and make it clear that there was a break in backwards compatibility. But, I'm ok with this so long as it makes the library more consistent.

from node-cron.

Hello,

When is this getting into the code? Currently, it's definitely inconsistent.

Thanks!

from node-cron.

I haven't seen a patch for this yet. I'm not sure if anyone is actively working on it.

from node-cron.

I can pick this up again at some point. @pixelfreak, are you more interested in the 5-digit crontime syntax or the day-of-week inconsistency?

from node-cron.

More interested in the day-of-week inconsistency. Thanks!

from node-cron.

Actually, I am curious why there exists two different cron format and which is better. For example, the linux cron we are all familiar with can't do seconds interval, but this one can. So maybe it's better to keep it that way?

from node-cron.

Since linux cron is the standard, personally I think node-cron should be consistent with its syntax/functionality. This would mean changing day-of-week to be consistent. Since the seconds interval doesn't contradict any standard cron syntax, it should just be an optional extended syntax (only if 6 digits are included). Will prepare the patch and see if people need backwards compatibility.

from node-cron.

Sounds good. I'll review it in a separate branch anyway before including it.
On Jul 23, 2012 10:05 PM, "Daniel Bear" <
[email protected]>
wrote:

Since linux cron is the standard, personally I think node-cron should be
consistent with its syntax/functionality. This would mean changing
day-of-week to be consistent. Since the seconds interval doesn't contradict
any standard cron syntax, it should just be an optional extended syntax
(only if 6 digits are included). Will prepare the patch and see if people
need backwards compatibility.

---

Reply to this email directly or view it on GitHub:
https://github.com/ncb000gt/node-cron/issues/36#issuecomment-7196981

from node-cron.

Alrighty, pull request up at https://github.com/ncb000gt/node-cron/pull/41. There are some comments in there. Let me know what you think.

from node-cron.

Completed with GH-41.

from node-cron.