Comments (10)
Hey,
Yes. I speak patches. :) I would like things to be consistent. Obviously both would break things so I'd upgrade the version and make it clear that there was a break in backwards compatibility. But, I'm ok with this so long as it makes the library more consistent.
from node-cron.
Hello,
When is this getting into the code? Currently, it's definitely inconsistent.
Thanks!
from node-cron.
I haven't seen a patch for this yet. I'm not sure if anyone is actively working on it.
from node-cron.
I can pick this up again at some point. @pixelfreak, are you more interested in the 5-digit crontime syntax or the day-of-week inconsistency?
from node-cron.
More interested in the day-of-week inconsistency. Thanks!
from node-cron.
Actually, I am curious why there exists two different cron format and which is better. For example, the linux cron we are all familiar with can't do seconds interval, but this one can. So maybe it's better to keep it that way?
from node-cron.
Since linux cron is the standard, personally I think node-cron should be consistent with its syntax/functionality. This would mean changing day-of-week to be consistent. Since the seconds interval doesn't contradict any standard cron syntax, it should just be an optional extended syntax (only if 6 digits are included). Will prepare the patch and see if people need backwards compatibility.
from node-cron.
Sounds good. I'll review it in a separate branch anyway before including it.
On Jul 23, 2012 10:05 PM, "Daniel Bear" <
[email protected]>
wrote:
Since linux cron is the standard, personally I think node-cron should be
consistent with its syntax/functionality. This would mean changing
day-of-week to be consistent. Since the seconds interval doesn't contradict
any standard cron syntax, it should just be an optional extended syntax
(only if 6 digits are included). Will prepare the patch and see if people
need backwards compatibility.
Reply to this email directly or view it on GitHub:
https://github.com/ncb000gt/node-cron/issues/36#issuecomment-7196981
from node-cron.
Alrighty, pull request up at https://github.com/ncb000gt/node-cron/pull/41. There are some comments in there. Let me know what you think.
from node-cron.
Completed with GH-41.
from node-cron.
Related Issues (20)
- Timezone Europe/Helsinki triggers onTick every seconds HOT 2
- Cron job stops after random hours/days HOT 14
- "Error: WARNING: Date in past. Will never be fired." crash inside callback wrapper HOT 6
- Something went wrong. cron reached maximum iterations HOT 1
- Type-level CRON expressions validation
- 不能设置数字0
- Cron not working on the correct date HOT 1
- Cron reached maximum iterations HOT 1
- Cron reach maximum duration (Version 3.1.6) HOT 1
- Add randomness to execution time HOT 3
- How can i stop the previous job? HOT 1
- type issue in CronJob HOT 7
- See all active cron jobs HOT 1
- Regex prevents valid syntax
- JavaScript error occurred in the main process HOT 1
- Javascript error occurred in the main process HOT 1
- Missing Cron Execution during DST change HOT 1
- Unraid api crash HOT 1
- The current Date is not accurate. HOT 1
- Incorrect Behavior in Setting Up a Cron Job for First Monday of the Month HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-cron.