Key binding not working on IE about jwerty HOT 15 OPEN

IE is a work-in-progress right now. I have been looking into supporting it in some kind of capacity, but it'll likely only be jQuery dependant.

This is a definite requirement for a 1.0 though - ideally I'd like to support IE9+ standalone, with support for IE6+ with jQuery as a dependency.

Thanks for the advice around the metaKey though, I'll definitely look into this!

from jwerty.

@keithamus - I created a fork and started working on adding IE support. It's not complete (only 2 of the 18 tests pass), so I haven't submitted a pull request, but thought you might be interested to see what I've done so far.

flesch@461acfc

from jwerty.

@flesch that is fantastic, thanks very much! I have a couple of things I want to chime in on this for now, with actual work to follow up later:

• I originally -- intentionally -- skipped attachEvent for many reasons, mostly because I'm stubborn and I don't want to code for IE when the lib also supports jQuery (and, I don't know anyone who would use this lib raw, for IE, without jQuery). Depending on the volume of complaints about lack of raw-js-ie support would decide whether I changed my mind or not.
• A lot of the tests are failing because of broken tests, not broken code. For example createEventObject/fireEvent isn't used in the tests to build any keyboard events, so where the code might have a change at passing for genuine keyboard events, it doesn't. I've actually got some un-committed code sitting here which fixes issues like these, and allows about 70% of the tests (with jQuery) to pass, so I'll commit this shortly.
• There is some really odd behaviour with the metaKey attrib in Windows with Internet Explorer. I know jQuery spent some time hashing this out and solving it. Something along the lines of that if ctrlKey is true, metaKey is undefined, unless shiftKey is present... I'd like to properly solve this before this lib is deemed "ie ready"

from jwerty.

It makes sense not to reinvent what jQuery's cracked, though I was hoping not to have it as a dependency (using Ender in a project now). So, +1...?

I have to admit I only tested a global hotkey (overriding CTRL+S) and one bound to a textarea, so where I'm checking p in event in the jwerty.is() loop, that only prevents IE from throwing an error.

I look forward to seeing what you have!

from jwerty.

Just out of curiosity, what are you using to bind/listen to events onto DOM elements? Maybe it'd be better to be able to support custom bind methods instead of just supporting IE?

from jwerty.

I apologize for the late answer. I am using jquery binding bind/delegate/live depending on the requirement :

jQuery(document)
         .unbind('.debugModal')
         .bind('keydown.debugModal.openDebug', jwerty.event(debugKey, loadDebugDetail));

jQuery('.detail-meta').delegate('.inplace input:text', 'keydown', jwerty.event('enter', function() {
...
}))

from jwerty.

That question was mostly for @flesch as he was suggesting fuller IE support. While I'm happy to support IE with jQuery/Ender I don't see much utility in providing event listener degradation for IE.

from jwerty.

Hello, first I'd like to say thanks for the plugin you created. I swear that I searched a lot something like these and I didn't find. I'm a webdesigner trying to be a little more complex and using this plugin to improve the acessibilty of my websites. But how some people noticed, the plugin doesn't work on internet explorer. Do you have a fix for it already or the project is closed?

Thanks Thiago dos Anjos from Brazil

from jwerty.

A fix is in the works, but I have been a bit busy with other projects, personal life, and my day job over the past two months. The project definitely isn't closed and I plan to start working on it as soon as I can. Thanks for the support!

from jwerty.

Ok thanks for the reply...You're very polite.

from jwerty.

It's bad that jwerty is not available for IE, because I was really hoping include it in our project.

According to unit tests, when I run them in IE9 having IE9-th rendering applied - all of tests pass except of one. But when I switch to IE8 mode - tests completely fail.

When should we expect new commits regarding IE? (I know I shouldn't ask that, but once I'm here...:)

from jwerty.

Sorry I should be updating the tests for these fairly soon - been a little busy with work and other projects.

from jwerty.

Any progress in IE support?

from jwerty.

What is the status of IE key binding? If it's not fixed, I'd be willing to put some money behind getting it fixed immediately. I only need IE9+ support.

from jwerty.

If I recall IE9 works fine, but I could be wrong, I haven't worked on this in a long time. If you want to put some money behind it, please, be my guest ;)

from jwerty.