<a target="_blank" rel="noopener noreferrer nofollow" href="https://cloud.githubuserco

Awesome! Merged here: <a class="commit-link" data-hovercard-type="commit" data-hoverca

Double brackets break string highlighting about swift.vim HOT 6 CLOSED

keith commented on May 18, 2024

Double brackets break string highlighting

from swift.vim.

Comments (6)

keith commented on May 18, 2024

Ugh. It looks like it's actually the opening [ that breaks it. I've said this before but I'll say it again, vim syntax highlighting is the worst.

from swift.vim.

keith commented on May 18, 2024

Looks like this is happening because of the swiftLiteralWrapper definition.

from swift.vim.

keith commented on May 18, 2024

Removed the conflicting type. Now this doesn't support a nice type but this is more important.

from swift.vim.

commented on May 18, 2024

@Keithbsmiley I got this to work just fine if I add swiftString to the contains attribute:

diff --git a/syntax/swift.vim b/syntax/swift.vim
index 89a38fb..fc15d4e 100644
--- a/syntax/swift.vim
+++ b/syntax/swift.vim
@@ -137,7 +137,7 @@ syntax keyword swiftStructure

 syntax region swiftTypeWrapper start="\v:\s*" end="\v[^\w]" contains=swiftString,swiftBoolean,swiftNumber,swiftType,swiftGenericsWrapper transparent oneline
 syntax region swiftGenericsWrapper start="\v\<" end="\v\>" contains=swiftType transparent oneline
-" syntax region swiftLiteralWrapper start="\v\=\s*" skip="\v[^\[\]]\(\)" end="\v(\[\]|\(\))" contains=swiftType transparent oneline
+syntax region swiftLiteralWrapper start="\v\=\s*" skip="\v[^\[\]]\(\)" end="\v(\[\]|\(\))" contains=swiftType,swiftString transparent oneline
 syntax region swiftReturnWrapper start="\v-\>\s*" end="\v(\{|$)" contains=swiftType transparent oneline
 syntax match swiftType "\v\u\w*" contained containedin=swiftGenericsWrapper,swiftTypeWrapper,swiftLiteralWrapper,swiftGenericsWrapper

from swift.vim.