Git Product home page Git Product logo

Comments (11)

varjolintu avatar varjolintu commented on July 16, 2024 1

It could be an option to disable restrictions for a certain page, but of course not as default. Using it as a default option could be a serious risk to anyone who wish (for some reason) to use autofill.

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

Maybe this is because the whole site is wrapped inside an iframe. Have to do some more debugging.

from keepassxc-browser.

mnpenner avatar mnpenner commented on July 16, 2024

I'm experiencing the same issue on one of my sites.

image

The "Username" field is not pickable. No iframes are used.

The HTML for the username field looks like

<input type="name" id="fakelogin" name="fakelogin" class="form-control" style="font-size:12px;padding:7px;width:80%" placeholder="Username" required="" autofocus="">

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

Thanks for these. I'm going to look at the issue today.

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

@mnpenner Have you been aware that HTML input type name is not a valid one. Of course we can add support for it but it's non-standard. I suggest you run your pages through a validator to see these kind of problems in time. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input.

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

@mestaritonttu It seems there's nothing I can do here even when I tried to make some nice hacks:

Uncaught DOMException: Failed to read the 'contentDocument' property from 'HTMLIFrameElement': Blocked a frame with origin "https://www.asiakastieto.fi" from accessing a cross-origin frame.

from keepassxc-browser.

mestaritonttu avatar mestaritonttu commented on July 16, 2024

Ok, thanks for trying. Asiakastieto needs a spanking for constructing such a silly thing.

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

Actually they originally had the login in field in a div (it's commented out) but for some reason they've switched to iframe.

from keepassxc-browser.

mnpenner avatar mnpenner commented on July 16, 2024

@varjolintu Hah...never noticed that. That code has been there forever. Thanks. I can fix that.

You might still consider making it less restrictive though, for all those sites outside our control.

Here's another example from tangerine.ca:

image

<input type="tel" name="login_pin" id="login_pin" class="input CB_DataMask ng-pristine ng-empty ng-invalid ng-invalid-required ng-valid-minlength ng-valid-maxlength ng-touched" ng-class="{warning:
              $ctrl.pinSectionForm.login_pin.$invalid &amp;&amp;
              $ctrl.pinSectionForm.login_pin.$touched &amp;&amp;
              $ctrl.pinSectionForm.login_pin.$dirty &amp;&amp;
              $ctrl.showErrorOn
            }" maxlength="6" minlength="4" numeric-input="" inputmode="numeric" in-view="$ctrl.pinInputInView($inview, $inviewInfo)" autofocus="" autofocus-device="ALL" autocomplete="off" ng-change="$ctrl.validateInput($ctrl.pinCredentials.PIN)" ng-keypress="$ctrl.onKeyPress($event)" ng-keyup="$ctrl.onNativeKeyPress($event)" ng-keydown="$ctrl.onNativeKeyPress($event)" ng-focus="$ctrl.onFocus()" ng-required="true" ng-blur="$ctrl.onBlur()" ng-model="$ctrl.pinCredentials.PIN" placeholder="4 or 6 digit Number" required="required" aria-invalid="true" data-cip-id="login_pin" style="">

It won't let me put my password into that box, presumably because its set to type="tel". I'm guessing they did this to get the number pad on mobile. They still masked input.

from keepassxc-browser.

varjolintu avatar varjolintu commented on July 16, 2024

That's... a lot of code for a single input.

The extension currently supports the following input types: text, email, password, tel, number and discards any input if the type is not set at all.

from keepassxc-browser.

mnpenner avatar mnpenner commented on July 16, 2024

¯\_(ツ)_/¯ That's Angular for you.

You could add an option to disable restrictions too. I'd personally prefer that it let me pick any field on the page. But I can see how highlighting everything might be less user-friendly, so making an option would be nice.

from keepassxc-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.