Comments (4)
yeah, you should update docs v2.10 and 2.11.
in the code, you have to add the scaler in this condition:
https://github.com/kedacore/keda/blob/739b770c8eecbfd0245cd76de02d25a3716d0900/controllers/keda/scaledobject_controller.go#L358-L360
from keda-docs.
This was changed in #1074 but I think you are correct.
@JorTurFer @zroubalik any objection in reverting this?
from keda-docs.
No from my side, we need to update keda code as well because you are right, in this scaler metricName
is required because it's used for the underlying SKD
Are you willing to open the PRs removing this metric from deprecations?
from keda-docs.
No from my side, we need to update keda code as well because you are right, in this scaler
metricName
is required because it's used for the underlying SKDAre you willing to open the PRs removing this metric from deprecations?
@JorTurFer Sure, I can do that. What version of azure-monitor.md
doc should be updated? 2.11 or 2.10 ?
Also are you saying that we should update something in the keda code besides doc edits in azure-monitor.md
? Could you point me to what needs to be changed in the code? I'll see if I can do that as well.
from keda-docs.
Related Issues (20)
- Provide documentation on polling intervals HOT 1
- Allow custom tolerance levels for ScaledObject HOT 2
- Provide detailed docs on how KEDA communicates with various components HOT 2
- Provide documentation on setting up authentication with GCP workload identity HOT 4
- [Question] Clarifications needed regarding auto scaling based on the Redis Stream HOT 1
- Provide troubleshooting guidance & checklist for Azure AD Workload Identity integration HOT 2
- Include missing parameters in the documentation for GCP Stackdriver Scaler
- Documented Prometheus Metric keda_scaler_activity is actually keda_scaler_active HOT 1
- Provide better description for the PAT permissions needed for the GitHub Runner scaler HOT 4
- Wrong transfer ownership annotation in the docs
- Github Runner scaler githubAPIURL parameter not matching documentation HOT 3
- Documentation wrong for vaultUri HOT 1
- Provide guidance on how to use Grafana cloud hosted prometheus as a scaler HOT 3
- Provide min max replica with cronjob HOT 2
- Azure Service Bus Session Count Scaler
- Sample python code to process messages from rabbitmq HOT 1
- Keda-metrics-server can't reach keda-operator HOT 1
- Redesign how we present troubleshooting information HOT 4
- Provide "Copy Link" button for FAQ questions HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keda-docs.