Why Azure Monitor Scaler metricName is deprecated about keda-docs HOT 4 CLOSED

yeah, you should update docs v2.10 and 2.11.
in the code, you have to add the scaler in this condition:
https://github.com/kedacore/keda/blob/739b770c8eecbfd0245cd76de02d25a3716d0900/controllers/keda/scaledobject_controller.go#L358-L360

from keda-docs.

This was changed in #1074 but I think you are correct.

@JorTurFer @zroubalik any objection in reverting this?

from keda-docs.

No from my side, we need to update keda code as well because you are right, in this scaler metricName is required because it's used for the underlying SKD

Are you willing to open the PRs removing this metric from deprecations?

from keda-docs.

No from my side, we need to update keda code as well because you are right, in this scaler metricName is required because it's used for the underlying SKD

Are you willing to open the PRs removing this metric from deprecations?

@JorTurFer Sure, I can do that. What version of azure-monitor.md doc should be updated? 2.11 or 2.10 ?

Also are you saying that we should update something in the keda code besides doc edits in azure-monitor.md ? Could you point me to what needs to be changed in the code? I'll see if I can do that as well.

from keda-docs.