Git Product home page Git Product logo

Comments (7)

kdavies4 avatar kdavies4 commented on August 23, 2024

Will be supported via a context manager: modelicares.exps.simulators.fmi

from modelicares.

arnoutaertgeerts avatar arnoutaertgeerts commented on August 23, 2024

Most of the implementation is done and works on Windows. I tried to stay as close as possible to your programming style of the dymosim class. 3f22fdc

If we need some other features, let me know!

from modelicares.

kdavies4 avatar kdavies4 commented on August 23, 2024

I got the following error when I tried simulations.ipynb:
AttributeError: 'pyfmi.fmi.FMUModelCS1' object has no attribute 'setup_experiment

I got a similar error with using ME instead of CS:
AttributeError: 'pyfmi.fmi.FMUModelME1' object has no attribute 'setup_experiment'

When I commented out the self.fmu.setup_experiment() line of exps.simulators.fmi.load and generated a FMU with a binary for my platform, that IPython notebook worked. What do you think happened? Do we have different versions of PyFMI? I think I have version 2.0.

from modelicares.

kdavies4 avatar kdavies4 commented on August 23, 2024

Otherwise, we mostly just need to clean things up (code, docstrings, examples). I need to do a sensitivity analysis (Morris method) using the exps module for my research. If that leads to any useful functions I'll add them. I'd like to release all this in a new version before the next Activity 1.4 mtg (mid to late Jan).

Good work!

from modelicares.

kdavies4 avatar kdavies4 commented on August 23, 2024

Here's an idea: instead of internally storing memory_result, run() and continue_run() could return the results as SimRes instances. The best way might be to extend the pyfmi results class (ResultBase or JMResultBase) on SimRes, but that would require agreement from the PyFMI developers.

from modelicares.

arnoutaertgeerts avatar arnoutaertgeerts commented on August 23, 2024

The AttributeError was due to a different version of the FMU, not of PyFMI. I fixed this in 1e0027f.

from modelicares.

kdavies4 avatar kdavies4 commented on August 23, 2024

Great!

from modelicares.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.