Comments (14)
@Vascom I created a new branch 1.4.2 which is the 1.4.1 release with the hotfix for the cve and kddw 2.0 support
Build with kddockwidgets 2.0 succesfull.
from hotspot.
Which feature should be disabled and how to do it?
Via the cmake option ALLOW_PRIVILEGE_ESCALATION
(disabled by default) but is only available after 65a246c
.
The CVE is only a vulnerability if disable the enter password dialog via polkit.
from hotspot.
@Vascom I created a new branch 1.4.2 which is the 1.4.1 release with the hotfix for the cve and kddw 2.0 support
from hotspot.
This is more a quick fix than a solution. We are trying to create a new release soon.
from hotspot.
finally: https://github.com/KDAB/hotspot/releases/tag/v1.5.0
from hotspot.
This is the error I get trying to build 1.4.1 with kddockwidgets 2.0.0:
[ 84%] Building CXX object src/CMakeFiles/hotspot.dir/mainwindow.cpp.o
cd /tmp/guix-build-hotspot-1.4.1.drv-0/build/src && /gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/bin/c++ -DKCOREADDONS_LIB -DKDDW_FRONTEND_QT -DKDDW_FRONTEND_QTQUICK -DKDDW_FRONTEND_QTWIDGETS -DKF_DEPRECATED_WARNINGS_SINCE=0x060000 -DQCUSTOMPLOT_USE_LIBRARY -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x060000 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_URL_CAST_FROM_STRING -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKCONTROLS2_LIB -DQT_QUICK_LIB -DQT_STRICT_ITERATORS -DQT_SVG_LIB -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/tmp/guix-build-hotspot-1.4.1.drv-0/build/src -I/tmp/guix-build-hotspot-1.4.1.drv-0/source/src -I/tmp/guix-build-hotspot-1.4.1.drv-0/build/src/hotspot_autogen/include -I/tmp/guix-build-hotspot-1.4.1.drv-0/build -I/tmp/guix-build-hotspot-1.4.1.drv-0/build/src/models -I/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/models -I/tmp/guix-build-hotspot-1.4.1.drv-0/source/3rdparty/PrefixTickLabels/src -I/tmp/guix-build-hotspot-1.4.1.drv-0/build/3rdparty -I/tmp/guix-build-hotspot-1.4.1.drv-0/source/3rdparty -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5 -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtWidgets -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtGui -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtCore -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/lib/qt5/mkspecs/linux-g++ -isystem /gnu/store/8rxh7dxsr5jagkxmzmlys242jy8l8p1v-qtsvg-5.15.10/include/qt5 -isystem /gnu/store/8rxh7dxsr5jagkxmzmlys242jy8l8p1v-qtsvg-5.15.10/include/qt5/QtSvg -isystem /gnu/store/pjx8rf94k27g7h75l1f4vi0jin1ygczk-threadweaver-5.114.0/include/KF5/ThreadWeaver -isystem /gnu/store/pjx8rf94k27g7h75l1f4vi0jin1ygczk-threadweaver-5.114.0/include/KF5 -isystem /gnu/store/898qm4jb5pq3zwg0a8ch246zv399ax56-kconfigwidgets-5.114.0/include/KF5/KConfigWidgets -isystem /gnu/store/898qm4jb5pq3zwg0a8ch246zv399ax56-kconfigwidgets-5.114.0/include/KF5 -isystem /gnu/store/ya4yy1z8v73s3yn7x7x2rm0j72mykwdf-kwidgetsaddons-5.114.0/include/KF5/KWidgetsAddons -isystem /gnu/store/ya4yy1z8v73s3yn7x7x2rm0j72mykwdf-kwidgetsaddons-5.114.0/include/KF5 -isystem /gnu/store/zwx25ar19x9lgl4wz9r7wfr903wyssss-kconfig-5.114.0/include/KF5/KConfig -isystem /gnu/store/zwx25ar19x9lgl4wz9r7wfr903wyssss-kconfig-5.114.0/include/KF5/KConfigGui -isystem /gnu/store/zwx25ar19x9lgl4wz9r7wfr903wyssss-kconfig-5.114.0/include/KF5 -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtXml -isystem /gnu/store/zwx25ar19x9lgl4wz9r7wfr903wyssss-kconfig-5.114.0/include/KF5/KConfigCore -isystem /gnu/store/z84hf2i2b83jxkcvfs3jwpghj4542ib5-kcoreaddons-5.114.0/include/KF5/KCoreAddons -isystem /gnu/store/z84hf2i2b83jxkcvfs3jwpghj4542ib5-kcoreaddons-5.114.0/include/KF5 -isystem /gnu/store/ixdbn616m9kj28in6l9z589flmpr0p9d-kcodecs-5.114.0/include/KF5/KCodecs -isystem /gnu/store/ixdbn616m9kj28in6l9z589flmpr0p9d-kcodecs-5.114.0/include/KF5 -isystem /gnu/store/syln8f9n66n15ic1qpq89246b1ss5rw6-kauth-5.114.0/include/KF5/KAuthWidgets -isystem /gnu/store/syln8f9n66n15ic1qpq89246b1ss5rw6-kauth-5.114.0/include/KF5 -isystem /gnu/store/syln8f9n66n15ic1qpq89246b1ss5rw6-kauth-5.114.0/include/KF5/KAuthCore -isystem /gnu/store/syln8f9n66n15ic1qpq89246b1ss5rw6-kauth-5.114.0/include/KF5/KAuth -isystem /gnu/store/1w9fgqqav2jh3kvbbw8qxf5ndb025mil-kitemviews-5.114.0/include/KF5/KItemViews -isystem /gnu/store/1w9fgqqav2jh3kvbbw8qxf5ndb025mil-kitemviews-5.114.0/include/KF5 -isystem /gnu/store/i7m25s59vad8pvmlparj4y27ffd5s2gs-kitemmodels-5.114.0/include/KF5/KItemModels -isystem /gnu/store/i7m25s59vad8pvmlparj4y27ffd5s2gs-kitemmodels-5.114.0/include/KF5 -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5/KIOCore -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5/KIO -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5 -isystem /gnu/store/sx1rqyida0hdrg8i12fglckvka5dv31w-kservice-5.114.0/include/KF5/KService -isystem /gnu/store/sx1rqyida0hdrg8i12fglckvka5dv31w-kservice-5.114.0/include/KF5 -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtNetwork -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtDBus -isystem /gnu/store/425g693qjdah373lbb2hjhzm3c9v02pf-qtbase-5.15.10/include/qt5/QtConcurrent -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5/KIOFileWidgets -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5/KIOWidgets -isystem /gnu/store/qc372mjpid7p3s9wm9ibxbylbcschr3q-kio-5.114.0/include/KF5/KIOGui -isystem /gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5/KWindowSystem -isystem /gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5 -isystem /gnu/store/35yaflkqgbd70zgwxxr9s45c91hkgb93-kjobwidgets-5.114.0/include/KF5/KJobWidgets -isystem /gnu/store/35yaflkqgbd70zgwxxr9s45c91hkgb93-kjobwidgets-5.114.0/include/KF5 -isystem /gnu/store/bavxg37hmfg2k7dyr6v86hz0gyjyihrx-solid-5.114.0/include/KF5/Solid -isystem /gnu/store/bavxg37hmfg2k7dyr6v86hz0gyjyihrx-solid-5.114.0/include/KF5 -isystem /gnu/store/ihznpdpwhwyb9qziaxsckw407ybwy7f7-kcompletion-5.114.0/include/KF5/KCompletion -isystem /gnu/store/ihznpdpwhwyb9qziaxsckw407ybwy7f7-kcompletion-5.114.0/include/KF5 -isystem /gnu/store/g18ghfgikac6f0jwvwccw9gv6jvp8zi4-kbookmarks-5.114.0/include/KF5/KBookmarks -isystem /gnu/store/g18ghfgikac6f0jwvwccw9gv6jvp8zi4-kbookmarks-5.114.0/include/KF5 -isystem /gnu/store/jswvx38g014gfz83d0x075rx1z0zvr47-kxmlgui-5.114.0/include/KF5/KXmlGui -isystem /gnu/store/jswvx38g014gfz83d0x075rx1z0zvr47-kxmlgui-5.114.0/include/KF5 -isystem /gnu/store/zkjzhyhx0wvfhaapxcjnj1fimp46lg3r-knotifications-5.114.0/include/KF5/KNotifications -isystem /gnu/store/zkjzhyhx0wvfhaapxcjnj1fimp46lg3r-knotifications-5.114.0/include/KF5 -isystem /gnu/store/z9amx5w6a6kjda7hglrypwzmlw6b3yxx-kiconthemes-5.114.0/include/KF5/KIconThemes -isystem /gnu/store/z9amx5w6a6kjda7hglrypwzmlw6b3yxx-kiconthemes-5.114.0/include/KF5 -isystem /gnu/store/2g502amnvaf56c7fc69iv3m9svrvi3h8-kparts-5.114.0/include/KF5/KParts -isystem /gnu/store/2g502amnvaf56c7fc69iv3m9svrvi3h8-kparts-5.114.0/include/KF5 -isystem /gnu/store/l6z6fb96b6bz67hn28yaw4zvprh5n5pl-ktextwidgets-5.114.0/include/KF5/KTextWidgets -isystem /gnu/store/l6z6fb96b6bz67hn28yaw4zvprh5n5pl-ktextwidgets-5.114.0/include/KF5 -isystem /gnu/store/pznhxxy7m5bpf615wk5vkwgbyliyk1z6-sonnet-5.114.0/include/KF5/SonnetUi -isystem /gnu/store/pznhxxy7m5bpf615wk5vkwgbyliyk1z6-sonnet-5.114.0/include/KF5/Sonnet -isystem /gnu/store/pznhxxy7m5bpf615wk5vkwgbyliyk1z6-sonnet-5.114.0/include/KF5 -isystem /gnu/store/nnfpqyplhfr0iilq1jgqayihpvi2xn32-ki18n-5.114.0/include/KF5/KI18n -isystem /gnu/store/nnfpqyplhfr0iilq1jgqayihpvi2xn32-ki18n-5.114.0/include/KF5 -isystem /gnu/store/cf9ig48n7d26sbmms70gfc725yd3k1qs-ksyntaxhighlighting-5.114.0/include/KF5/KSyntaxHighlighting -isystem /gnu/store/i5mkjrxmyybshk3ka3m47piqv77698gz-qtdeclarative-5.15.10/include/qt5 -isystem /gnu/store/i5mkjrxmyybshk3ka3m47piqv77698gz-qtdeclarative-5.15.10/include/qt5/QtQuick -isystem /gnu/store/i5mkjrxmyybshk3ka3m47piqv77698gz-qtdeclarative-5.15.10/include/qt5/QtQmlModels -isystem /gnu/store/i5mkjrxmyybshk3ka3m47piqv77698gz-qtdeclarative-5.15.10/include/qt5/QtQml -isystem /gnu/store/4011bxwbpj51rxq9n739dr29iqdwrnhj-qtquickcontrols2-5.15.10/include/qt5 -isystem /gnu/store/4011bxwbpj51rxq9n739dr29iqdwrnhj-qtquickcontrols2-5.15.10/include/qt5/QtQuickControls2 -isystem /gnu/store/slpryl8hr3fnw8g45qd5ms767wvpcxk3-qtx11extras-5.15.10/include/qt5 -isystem /gnu/store/slpryl8hr3fnw8g45qd5ms767wvpcxk3-qtx11extras-5.15.10/include/qt5/QtX11Extras -isystem /gnu/store/jwnaipyy1khvwybcvwvj7jw7j3w6y6qh-karchive-5.114.0/include/KF5/KArchive -isystem /gnu/store/jwnaipyy1khvwybcvwvj7jw7j3w6y6qh-karchive-5.114.0/include/KF5 -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -pedantic -Wzero-as-null-pointer-constant -O2 -g -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++14 -MD -MT src/CMakeFiles/hotspot.dir/mainwindow.cpp.o -MF CMakeFiles/hotspot.dir/mainwindow.cpp.o.d -o CMakeFiles/hotspot.dir/mainwindow.cpp.o -c /tmp/guix-build-hotspot-1.4.1.drv-0/source/src/mainwindow.cpp
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/perfrecord.cpp: In function ‘QStringList sudoOptions(const QString&)’:
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/perfrecord.cpp:68:55: warning: ‘static WId KWindowSystem::activeWindow()’ is deprecated: Since 5.101. Use KX11Extras::activeWindow() instead [-Wdeprecated-declarations]
68 | options.append(QString::number(KWindowSystem::activeWindow()));
| ^~~~~~~~~~~~
In file included from /gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5/KWindowSystem/KWindowSystem:1,
from /tmp/guix-build-hotspot-1.4.1.drv-0/source/src/perfrecord.cpp:23:
/gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5/KWindowSystem/kwindowsystem.h:126:16: note: declared here
126 | static WId activeWindow();
| ^~~~~~~~~~~~
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/perfrecord.cpp:68:67: warning: ‘static WId KWindowSystem::activeWindow()’ is deprecated: Since 5.101. Use KX11Extras::activeWindow() instead [-Wdeprecated-declarations]
68 | options.append(QString::number(KWindowSystem::activeWindow()));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5/KWindowSystem/KWindowSystem:1,
from /tmp/guix-build-hotspot-1.4.1.drv-0/source/src/perfrecord.cpp:23:
/gnu/store/7pq81bwnxvw128ms8dwv1bhp1zsyjpjb-kwindowsystem-5.114.0/include/KF5/KWindowSystem/kwindowsystem.h:126:16: note: declared here
126 | static WId activeWindow();
| ^~~~~~~~~~~~
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/mainwindow.cpp: In constructor ‘MainWindow::MainWindow(QWidget*)’:
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/mainwindow.cpp:265:36: error: cannot convert ‘const QVector<KDDockWidgets::Core::DockWidget*>’ to ‘const QVector<KDDockWidgets::DockWidgetBase*>&’
265 | m_resultsPage->initDockWidgets(restored);
| ^~~~~~~~
| |
| const QVector<KDDockWidgets::Core::DockWidget*>
In file included from /tmp/guix-build-hotspot-1.4.1.drv-0/source/src/mainwindow.cpp:12:
/tmp/guix-build-hotspot-1.4.1.drv-0/source/src/resultspage.h:55:73: note: initializing argument 1 of ‘void ResultsPage::initDockWidgets(const QVector<KDDockWidgets::DockWidgetBase*>&)’
55 | void initDockWidgets(const QVector<KDDockWidgets::DockWidgetBase*>& restored);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
from hotspot.
1.4.1 builds fine with kddockwidgets 1.7.0, but 2 tests failed:
starting phase `check'
Running tests...
/gnu/store/gl26kr5v6ch5lc3ignly61kb224drijc-cmake-minimal-3.24.2/bin/ctest --force-new-ctest-process
Test project /tmp/guix-build-hotspot-1.4.1.drv-0/build
Start 1: tst_elfmap
1/8 Test #1: tst_elfmap ....................... Passed 7.76 sec
Start 2: tst_addresscache
2/8 Test #2: tst_addresscache ................. Passed 0.03 sec
Start 3: tst_perfdata
3/8 Test #3: tst_perfdata ..................... Passed 0.28 sec
Start 4: tst_models
4/8 Test #4: tst_models .......................***Failed 0.74 sec
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/guix-build-hotspot-1.4.1.drv-0/runtime-nixbld'
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/guix-build-hotspot-1.4.1.drv-0/runtime-nixbld'
********* Start testing of TestModels *********
Config: Using QtTest library 5.15.10, Qt 5.15.10 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.3.0), unknown unknown
PASS : TestModels::initTestCase()
PASS : TestModels::testTreeParents()
PASS : TestModels::testBottomUpModel()
1
2
↪3
4
5
6
7
8
9
10
11
12
13
14
PASS : TestModels::testSimplifiedModel()
Actual:
A=s:0,i:7
B=s:0,i:7
C=s:1,i:5
E=s:1,i:3
C=s:1,i:2
E=s:1,i:1
C=s:1,i:1
D=s:2,i:2
C=s:2,i:2
Expected:
A=s:0,i:7
B=s:0,i:7
C=s:1,i:5
E=s:1,i:3
C=s:1,i:2
E=s:1,i:1
C=s:1,i:1
D=s:2,i:2
C=s:2,i:2
PASS : TestModels::testTopDownModel(normal)
Actual:
T1=s:0,i:7
A=s:0,i:6
B=s:0,i:6
C=s:1,i:5
E=s:1,i:3
C=s:1,i:2
E=s:1,i:1
C=s:1,i:1
D=s:1,i:1
C=s:1,i:1
T2=s:0,i:2
A=s:0,i:1
B=s:0,i:1
D=s:1,i:1
C=s:1,i:1
Expected:
T1=s:0,i:7
A=s:0,i:6
B=s:0,i:6
C=s:1,i:5
E=s:1,i:3
C=s:1,i:2
E=s:1,i:1
C=s:1,i:1
D=s:1,i:1
C=s:1,i:1
T2=s:0,i:2
A=s:0,i:1
B=s:0,i:1
D=s:1,i:1
C=s:1,i:1
PASS : TestModels::testTopDownModel(skipFirstLevel)
PASS : TestModels::testTopProxy()
Actual:
A=s:0,i:7
A>B=7
B=s:0,i:7
B<A=7
B>C=5
B>D=2
C=s:5,i:7
C<B=5
C<C=1
C<E=2
C>C=1
C>E=3
D=s:2,i:2
D<B=2
E=s:2,i:3
E<C=3
E>C=2
Expected:
A=s:0,i:7
A>B=7
B=s:0,i:7
B<A=7
B>C=5
B>D=2
C=s:5,i:7
C<B=5
C<C=1
C<E=2
C>C=1
C>E=3
D=s:2,i:2
D<B=2
E=s:2,i:3
E<C=3
E>C=2
Actual Model:
A=s:0,i:7
A>B=7
B=s:0,i:7
B<A=7
B>C=5
B>D=2
C=s:5,i:7
C<B=5
C<C=1
C<E=2
C>C=1
C>E=3
D=s:2,i:2
D<B=2
E=s:2,i:3
E<C=3
E>C=2
PASS : TestModels::testCallerCalleeModel()
Fontconfig error: No writable cache directories
Fontconfig error: No writable cache directories
PASS : TestModels::testDisassemblyModel(curSymbol)
PASS : TestModels::testSourceCodeModelNoFileName(curSymbol)
PASS : TestModels::testEventModel()
PASS : TestModels::testPrettySymbol(string)
PASS : TestModels::testPrettySymbol(wstring)
PASS : TestModels::testPrettySymbol(basic_string)
PASS : TestModels::testPrettySymbol(vector)
PASS : TestModels::testPrettySymbol(map)
PASS : TestModels::testPrettySymbol(nested types)
PASS : TestModels::testPrettySymbol(standard type)
PASS : TestModels::testPrettySymbol(custom type)
PASS : TestModels::testPrettySymbol(custom nested template)
PASS : TestModels::testPrettySymbol(custom template)
PASS : TestModels::testPrettySymbol(mystd)
PASS : TestModels::testPrettySymbol(mystd template)
PASS : TestModels::testPrettySymbol(function pointer)
PASS : TestModels::testPrettySymbol(pair)
PASS : TestModels::testPrettySymbol(list)
PASS : TestModels::testPrettySymbol(set)
PASS : TestModels::testPrettySymbol(multiset)
PASS : TestModels::testPrettySymbol(multimap)
PASS : TestModels::testPrettySymbol(deque)
PASS : TestModels::testPrettySymbol(stack)
PASS : TestModels::testPrettySymbol(array)
PASS : TestModels::testPrettySymbol(forward_list)
PASS : TestModels::testPrettySymbol(unordered_set)
PASS : TestModels::testPrettySymbol(unordered_map)
PASS : TestModels::testPrettySymbol(unordered_multiset)
PASS : TestModels::testPrettySymbol(unordered_multimap)
PASS : TestModels::testPrettySymbol(bound function)
PASS : TestModels::testCollapseTemplates(operator<)
PASS : TestModels::testCollapseTemplates(operator>)
PASS : TestModels::testCollapseTemplates(operator<<)
PASS : TestModels::testCollapseTemplates(operator>>)
PASS : TestModels::testCollapseTemplates(operator <)
PASS : TestModels::testCollapseTemplates(operator >)
PASS : TestModels::testCollapseTemplates(operator <<)
PASS : TestModels::testCollapseTemplates(operator >>)
PASS : TestModels::testCollapseTemplates(operator< 2)
PASS : TestModels::testCollapseTemplates(operator> 2)
PASS : TestModels::testCollapseTemplates(operator<< 2)
PASS : TestModels::testCollapseTemplates(operator>> 2)
PASS : TestModels::testSymbolEliding(no eliding)
FAIL! : TestModels::testSymbolEliding(elide arguments) Compared values are not the same
Actual (Util::elideSymbol(testSymbol, monospaceMetrics(), maxWidth)): "asdf_namespace::foobar<asdf, yxcvyxcv>::blablub(someotherreall\u2026) const"
Expected (elidedSymbol) : "asdf_namespace::foobar<asdf, yxcvyxcv>::blablub(someotherreallylongn\u2026) const"
Loc: [/tmp/guix-build-hotspot-1.4.1.drv-0/source/tests/modeltests/tst_models.cpp(755)]
PASS : TestModels::testSymbolEliding(elide templates)
FAIL! : TestModels::testSymbolEliding(elide symbol) Compared values are not the same
Actual (Util::elideSymbol(testSymbol, monospaceMetrics(), maxWidth)): "\u2026r<\u2026>::blablub(\u2026) const"
Expected (elidedSymbol) : "\u2026obar<\u2026>::blablub(\u2026) const"
Loc: [/tmp/guix-build-hotspot-1.4.1.drv-0/source/tests/modeltests/tst_models.cpp(755)]
FAIL! : TestModels::testSymbolElidingParanthese() Compared values are not the same
Actual (Util::elideSymbol(symbol, metrics, metrics.averageCharWidth() * 54)): "Foo<&bar::operator()>::asdf<XYZ>(blabla<&foo::\u2026)"
Expected ("Foo<&bar::operator()>::asdf<XYZ>(blabla<&foo::opera…)") : Foo<&bar::operator()>::asdf<XYZ>(blabla<&foo::opera…)
Loc: [/tmp/guix-build-hotspot-1.4.1.drv-0/source/tests/modeltests/tst_models.cpp(766)]
PASS : TestModels::cleanupTestCase()
Totals: 53 passed, 3 failed, 0 skipped, 0 blacklisted, 456ms
********* Finished testing of TestModels *********
Start 5: tst_timelinedelegate
5/8 Test #5: tst_timelinedelegate ............. Passed 0.07 sec
Start 6: tst_disassemblyoutput
6/8 Test #6: tst_disassemblyoutput ............ Passed 0.09 sec
Start 7: tst_callgraphgenerator
7/8 Test #7: tst_callgraphgenerator ...........Subprocess aborted***Exception: 10.36 sec
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/guix-build-hotspot-1.4.1.drv-0/runtime-nixbld'
********* Start testing of TestCallgraphGenerator *********
Config: Using QtTest library 5.15.10, Qt 5.15.10 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.3.0), unknown unknown
FAIL! : TestCallgraphGenerator::initTestCase() 'recordingFinishedSpy.wait(10000)' returned FALSE. ()
Loc: [/tmp/guix-build-hotspot-1.4.1.drv-0/source/tests/modeltests/tst_callgraphgenerator.cpp(110)]
FAIL! : TestCallgraphGenerator::initTestCase() Caught unhandled exception
Loc: [qtestcase.cpp(1941)]
Totals: 0 passed, 2 failed, 0 skipped, 0 blacklisted, 10297ms
********* Finished testing of TestCallgraphGenerator *********
terminate called after throwing an instance of 'std::logic_error'
what(): verify failed: recordingFinishedSpy.wait(10000)
Start 8: tst_perfparser
8/8 Test #8: tst_perfparser ................... Passed 0.09 sec
75% tests passed, 2 tests failed out of 8
Total Test time (real) = 19.45 sec
The following tests FAILED:
4 - tst_models (Failed)
7 - tst_callgraphgenerator (Subprocess aborted)
Errors while running CTest
make: *** [Makefile:74: test] Error 8
from hotspot.
Apparently 1.4.1 (and current master it seems) also contains a potential vulnerability, known as CVE-2023-28144.
from hotspot.
The CVE has been fixed since fa4ddd9 (about 9 months ago)
from hotspot.
1.4.1 is affected (if you use this feature). Most distros have this fixed by disabling the feature. In master we use a different approach that fixes this vulnerability to my knowledge.
1.4 does not support KDDW 2.
Generally: yes, we need to make an official new release. In the meantime, if you want to compile stuff yourself, just use master or an appimage from one of the recent master builds.
from hotspot.
Which feature should be disabled and how to do it?
from hotspot.
I maintain kddockwidgets at Fedora GNU/Linux and want update it to 2.0.0. But hotspot 1.4.1 not support build with this version and require many patches to add it.
@Vascom Can you please provide these patches as a PR? Otherwise "a new release" won't help with the KDDW2 part either...
from hotspot.
I guess this patches already in hotspot's master branch.
from hotspot.
I do wonder if it makes to also update perfparser there, possibly also the "GUI <-> cmdline commits 1d1d278, 25e880c and 88bbd96 to fix #613 then doing a 1.4.2 release from that branch?
This would allow to work on a newer version in master with stable disassembly (a bunch of things are broken but I think most have a PR in line) to then aim for possibly a new feature release from master in May (or whenever time permits that)?
from hotspot.
Related Issues (20)
- Flamegraph is not repainted correctly when zooming out HOT 5
- Crash(Assertion failure) when opening large data HOT 2
- Can't show complete info in flame graph. HOT 5
- After upgrading project to C++20, hotspot shows incorrect flamegraph/stacktrace HOT 7
- "Failed to export flamegraph: image is empty". HOT 3
- Update Readme
- Konsole not working when recording HOT 1
- Crash in disassembler
- Can't select directory when choosing sysroot
- Can/will it be possible to use hotspot with framepointers? HOT 1
- SIGSEGV 1.5.1 when closing during perf reading
- provide an option to export/import configuration and allow specifying used one via command line HOT 1
- Could not find plugin konsolepart (v1.5.1) HOT 2
- Undefined references against qcustomplot QList<double> functions HOT 3
- cost by location
- caller/callee: optional "extended" search
- FR Inspection of individual trace events with their respective parameters HOT 3
- Undocking time line window results in a freeze for the time line
- debuginfod: Only download debug info for hot functions HOT 2
- Disassembly view not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hotspot.