Request: allow disabling shared lib download behavior at build time about kcl-go HOT 8 CLOSED

Thanks for the work! I'll try building the latest tag this weekend alongside the Rust lib and give you the feedback when I'm done testing stuff.

from kcl-go.

Sorry for the delay! I've briefly tested the latest CLI version, and the variables seem to work correctly.

AlpineLinux is going through a major Python version bump, so I'm not able to build the Rust lib to test things thoroughly (at least for a week or so), but this issue can be closed. I'll open another issue on the main repo if a problem comes up.

from kcl-go.

A very good suggestion, do we need another issue to track the Alpine version of building the KCL Rust library?

I will try to implement it next week, but until then, PRs are very welcome. ❤️

from kcl-go.

I opened a PR to preliminarily implement it, is this the way you want it?

#259

from kcl-go.

Sorry for my misleading suggestion! What I meant by setting at build time is is to use -ldflags of go build command with -X option to inject the values of internal variables, which only supports string type.

Maybe something like this, I don't know:

var (
	LibHome                  string
	DisableInstallArtifact   string
	DisableUseArtifactInPath string
)

# then check whether the above variables are empty string, or already set by runtime env KCL_*

Minor comments:

Also, I think DisableUseArtifactInPath isn't really useful. Would downloading artifacts into the same directory as kcl for both MacOS and Linux make it simpler, and more consistent? Then we only need to require kclvm_cli is inside PATH.

from kcl-go.

I see. I will open another PR to handle variable injection for the build time. The PR is here #267

from kcl-go.

Sorry for another complaint! The new PR doesn't work. disableInstallArtifact and disableArtifactInPath are boolean, while -X flag only supports variables of string type (-ldflags "-X kcl-lang.io/kcl-go/pkg/env.disableArtifactInPath=true" won't affect the value). I can set libHome normally though, as it's ... string 😄

from kcl-go.

Sorry, I forgot to set them as string fields. #270

from kcl-go.