Git Product home page Git Product logo

Comments (10)

kaxil avatar kaxil commented on August 15, 2024 1

@kaxil it works perfectly on our private repos now 👍

Awesome 🎉 . Going to close this issue then :)

Not sure if you're open to contributors, but would love to customise the title validation status (like a custom error message or title for that), and to be able to set it to always use the PR title.

Of course, very open to contributions :) I spend most of my time contributing to https://github.com/apache/airflow and created the bot to implement some features we wanted and to generalize it so that anyone can use it too.

Please feel free to raise PR as I would love contributions :)

from boring-cyborg.

kaxil avatar kaxil commented on August 15, 2024 1

hmm that is so weird, I used it on one of my private repos and know few folks who do the same. I will try again over the weekend to see if something changed

from boring-cyborg.

kaxil avatar kaxil commented on August 15, 2024

@clarkd

For the app to work on Private Repo, we have requested adding read-only permission on a single file ".github/boring-cyborg.yml", please grant the additional permission and it should work on Private Repo too

cc @reececomo

from boring-cyborg.

kaxil avatar kaxil commented on August 15, 2024

@clarkd Any luck after your approved the updated permission request?

from boring-cyborg.

reececomo avatar reececomo commented on August 15, 2024

@kaxil it works perfectly on our private repos now 👍

Not sure if you're open to contributors, but would love to customise the title validation status (like a custom error message or title for that), and to be able to set it to always use the PR title.

from boring-cyborg.

marceloalmeida avatar marceloalmeida commented on August 15, 2024

@kaxil this issue still persists on private repositories on the "PR/Branch Up-To-Date Checker" feature. Any hints?

from boring-cyborg.

kaxil avatar kaxil commented on August 15, 2024

@kaxil this issue still persists on private repositories on the "PR/Branch Up-To-Date Checker" feature. Any hints?

It should work fine as long as you give permissions to the App

from boring-cyborg.

marceloalmeida avatar marceloalmeida commented on August 15, 2024

@kaxil this issue still persists on private repositories on the "PR/Branch Up-To-Date Checker" feature. Any hints?

It should work fine as long as you give permissions to the App

The app has the following permissions image
Is there any way to give extra permissions?

Just a small note, I've tested on the repository by changing the visibility (public and private) and when it's on public it works smoothly, on private the check even didn't appear on the PR

I'm guessing that we also need this permission - https://github.com/kaxil/boring-cyborg/blob/master/app.yml#L65

from boring-cyborg.

kaxil avatar kaxil commented on August 15, 2024

I just tried it on a private repo, installed the app and worked fine. Screenshot below, both title validate and labels were added. Check if the YAML file (.github/boring-cyborg.yml) is correct, it might be that the YAML isn't valid @marceloalmeida

image

from boring-cyborg.

marceloalmeida avatar marceloalmeida commented on August 15, 2024

I have labelPRBasedOnFilePath working the private repository, but unfortunately, the checkUpToDate isn't working, only works on public repositories.

Here it goes a piece of the .github/boring-cyborg.yml @kaxil - The current repository that I'm using for tests is this one - https://github.com/marceloalmeida/test-boring (right now is public)

checkUpToDate:
  # The default branch is "master", change the branch if you want to check against a different target branch  
  targetBranch: main
  files:
    - airflow/migrations/*
    - airflow/migrations/**/*
    - airflow/alembic.ini

from boring-cyborg.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.