Git Product home page Git Product logo

Comments (5)

Katsute avatar Katsute commented on June 26, 2024

Possibly add internal interface method init() to initialize and update objects, rather than seting the value directly on the variable and instantiation.

This could open the door to using protected/package-private initializers.

ex: instead of copying and pasting the static route initialization across all route implementations, use a single initializer RouteSchema#init(Route route) and set the values using route.??? = ???

private final String routeID = id;
private final String routeShortName = row.get(csv.getHeaderIndex("route_short_name"));
private final String routeLongName = row.get(csv.getHeaderIndex("route_long_name"));
private final String routeDesc = row.get(csv.getHeaderIndex("route_desc"));
private final String routeColor = row.get(csv.getHeaderIndex("route_color"));
private final String routeTextColor = row.get(csv.getHeaderIndex("route_text_color"));

vs

protected final String routeID = id;
  
protected final String routeShortName; 
protected final String routeLongName; 
protected final String routeDesc; 
  
protected final String routeColor; 
protected final String routeTextColor;
protected final void init(Route route){
   route.routeShortName = row.get(csv.getHeaderIndex("route_short_name"));
   ...
}

from onemta.

Katsute avatar Katsute commented on June 26, 2024

Only realtime data should be updated, static data should be final. Any arrays should also be regenerated and reassigned, don't update existing arrays.

from onemta.

Katsute avatar Katsute commented on June 26, 2024

First comment method can't be used, protected variables in abstract is not allowed.

Instead move update method to the alerts and vehicles array method. Have optional param update? to determine if class should regenerated arrays, rather than using existing; again use new array, do not update old one.

from onemta.

Katsute avatar Katsute commented on June 26, 2024

@sinon-bot branch refresh

from onemta.

 avatar commented on June 26, 2024

New branch created refresh@efe23fe

This branch was created by @Katsute.

from onemta.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.