Git Product home page Git Product logo

Comments (7)

jottinger avatar jottinger commented on August 16, 2024 1

@chimbori-dev one core feature crux is missing from snacktory is the mechanism for converting the Document to a simple text string after extracting content. I don't see a way to file an issue on the crux project page, however.

from snacktory.

karussell avatar karussell commented on August 16, 2024

Interesting and nice effort! I'm open for everything, from moving snacktory to you or giving you access to this repo or just marking it as deprecated and linking to your repo prominently.

from snacktory.

chimbori avatar chimbori commented on August 16, 2024

Cool! I’m not 100% sure what the best way forward is, so we could start with the least risky one: if you can add a pointer in the README directing people to the new one, that’d be awesome.

I don’t want to be the one to kill Snacktory, I’m sure a lot of apps depend on it — though there haven’t been updates. Crux is not a drop-in replacement because of the slightly different API.

Eventually, we can re-evaluate and pursue measures that will let apps move to Crux at their pace. What do you think?

from snacktory.

karussell avatar karussell commented on August 16, 2024

Sounds good. Maybe you create a PR regarding the changes of the README? So that you can make the reference as bold as necessary as you think :) ?

from snacktory.

chimbori avatar chimbori commented on August 16, 2024

The JSoup Document object already provides a text() method, and it’s the primary interface that Crux returns. This is fully intentional, to avoid duplicate methods and to allow you to control how you want the text. E.g. if you want multi-paragraph text, you can use walk the childNodes in that Document and get the text() from them instead.

Does that satisfy your requirement?

from snacktory.

chimbori avatar chimbori commented on August 16, 2024

Just enabled Issues on the Crux GitHub repo too, so we can take this discussion there if you’d like.

from snacktory.

jottinger avatar jottinger commented on August 16, 2024

Thanks - I realized after mentioning it here that the method was exposed on Document and worked like the old snacktory text reference. Silly me, I wasn't thinking about the JSoup API.

from snacktory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.