Git Product home page Git Product logo

Comments (7)

ptrthomas avatar ptrthomas commented on May 25, 2024

tagging this as help wanted. personally I feel workarounds are fine, refer: https://stackoverflow.com/a/61393515/143475

from karate.

djasani avatar djasani commented on May 25, 2024

Thanks @ptrthomas for the response. The problem with Robot workaround is, it only works if file exists on the host where tests are executing. We execute our test suite on Saucelab from the pipeline. Currently as a workaround, we are using RemoteWebDriver's hidden API to post attachement to the remote host and then upload file from remote host location. I did cloned Karate code today and was able to make file upload working for both WebDriver and DevToolsDriver.

from karate.

ptrthomas avatar ptrthomas commented on May 25, 2024

@djasani yes if you can submit a PR, that would be the best option

from karate.

djasani avatar djasani commented on May 25, 2024

@ptrthomas After finishing my implementation I realized that you have already implemented this feature for DevToolsDriver. It's has been implemented in the method "inputFile". I did not find similar method for WebDriver and PlaywrightDriver so I will implement and create PR after that.

Somehow I am not able to run using PlaywrightDriver from Karate-Core. It opens Chromium but just keeps waiting after WebSocket connection is established. However I am able to make it work for Playwright Driver in Karate-Playwright module.

from karate.

djasani avatar djasani commented on May 25, 2024

@ptrthomas I have executed LocalParallelRunner, PlaywrightRunner and LocalSingleRunner (chromedriver) after my changes. Previously we were only performing file upload when browserType was only Chrome. I have commented following line in the feature file 08.feature so file upload occurs for all different browserType.

#* if (driverType != 'chrome') karate.abort()

I also had to refactor 09.feature file to make this run in playwright. I believe playwright is handling frames differently.

Please find attached here are the results for karate-e2e-tests
karate-reports-LocalParallelRunner.zip
karate-reports-PlaywrightRunner.zip
karate-reports-chromedriver-LocalSingleRunner.zip

from karate.

ptrthomas avatar ptrthomas commented on May 25, 2024

@djasani thanks ! I'm a little extra busy at the moment so will request if @f-delahaye can take a look

from karate.

f-delahaye avatar f-delahaye commented on May 25, 2024

@ptrthomas Will do.
@djasani out of curiosity, any idea what was not working/was changed in 09.feature for Playwright?

from karate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.