PDF working on Windows about pennywise HOT 16 CLOSED

Was this not merged I thought it was?

could we not use the inbuilt one inside of chromium

from pennywise.

@The-Code-Monkey We need a plugin to use the inbuilt chromium one in electron.

@kamranahmedse closed my PR as he thought that it would have issues in platforms other than Mac. Also, he doesn't want to maintain Pennywise as a PDF viewer.

You can check the current roadmap for the app's intent

from pennywise.

thats fine but i thought it was supposed to open files?

from pennywise.

Yeah, now it isn't supposed to. Only websites

from pennywise.

Well at the end of the day it's his repo up to him.

from pennywise.

I'm maintaining the file opening goal in my fork : https://github.com/akash-joshi/pennywise-plus

from pennywise.

Check my version will allow you to open images, json and other files that chrome natively opens you just have to write it like file:///path/path/path

from pennywise.

All i need to do is put the keyboard shortcut in to open it

from pennywise.

@The-Code-Monkey You can use my code for the keyboard shortcut. Come on Twitter

I'll test this on Windows too

from pennywise.

I am still planning on adding the open file support – it's just the PDF opening that I had wavering in my mind about; but that also, I am testing @akash-joshi's PR on any Linux distro today and if it works fine, I will pull it in. Thank you!

from pennywise.

I am unable to do any more work until later today but i will use your shortcut and stuff @akash-joshi

from pennywise.

@kamranahmedse No worries, my friend ! I am trying to implement it without libs with @The-Code-Monkey in the meantime.

from pennywise.

@The-Code-Monkey Your method works for everything except pdfs. So I guess we still need to use the plugin for pdfs.

Tested for images, videos, audios

Working on both Mac and Windows

from pennywise.

Does it work with the cmd + o

from pennywise.

Yes

from pennywise.

Thank you. Will be deployed in the next release.

from pennywise.