Track Progress -- Open local PDFs (Working now) about pennywise HOT 17 CLOSED

@kamranahmedse Should this be implemented by using a JS library to display the PDF ?

Various Electron implementations here : https://electronjs.org/apps

Let me know what we should use, as I would like to work on this.

Update : Apparently electron can use Chrome's default pdf viewer https://stackoverflow.com/questions/45874719/opening-pdf-files-in-electron

from pennywise.

Yeah I would say use the default chromium one

from pennywise.

Tried using file input via <input type="file"> but as it returns fakepath, it can't be used

Update : Passing path of pdf as URL just causes it to download. Similar result by calling mainWindow.loadURL on the pdf. Might have to use plugin.

Update 2 : IT FLOATS ! Could get PDF support via plugin and command line. Now to somehow get location of file and pass it as event to electron.

See the last 2 commits in my repo to see how I did it : https://github.com/akash-joshi/pennywise

from pennywise.

Things which need to be improved : Check for extension; this is useful when media support is added

from pennywise.

The reason you get fake path is because JavaScript can't get access to filepaths you need to do new fileReader

from pennywise.

@The-Code-Monkey It's working now. Check out my fork

from pennywise.

Ok will do.

from pennywise.

@The-Code-Monkey Now in #47

from pennywise.

Im not sure how it works ive selected a file and its not clear what im supposed to do next?

from pennywise.

Ive added some styles i will make a pr to your fork ive not modified any of the files except from adding some styles to make it not the default button.

from pennywise.

Wait

from pennywise.

I've removed that, check #47 . Are you on twitter, Tele or somewhere ? For faster communication

from pennywise.

I'm on twitter @exoticcollector

from pennywise.

Ive got the loaded file console logging the base 64 for the file it just need to now be displayed onto the page but im unsure of how you have set the rest of it up.

from pennywise.

I have pushed to my local master branch if you want to take a look at what i have done i cant do much more today

from pennywise.

From #47, you just have to go under file -> open, or press cmd or ctrl + O and select the pdf you want to open.

from pennywise.

Ah ok

from pennywise.