Git Product home page Git Product logo

Comments (7)

malachid avatar malachid commented on May 30, 2024 1

I ran into the same thing. It falls through the bottom of the script and exits with exit code 0.
It's because of this part:
## Show the detail only if it is a git repository
if [[ -d ".git" || -f ".git" ]] ; then

from git-standup.

dgarrick avatar dgarrick commented on May 30, 2024

I believe I have a solution for this. If possible, I'd like to mess with it over the weekend and see if I can come up with a PR.

EDIT: I've implemented my solution locally and tested it with most of the flags, and it works with all of them. I'll continue testing, but any info on the preferred method to submit a PR would be great.

from git-standup.

jb08 avatar jb08 commented on May 30, 2024

@dgarrick great! push the change to your local forked git-standup, then make a PR to this upstream repo. nice job

from git-standup.

dgarrick avatar dgarrick commented on May 30, 2024

@jb08 I considered doing so, but it seems that there are a lot of good PR's just sitting around in this repo. I would still need to clean up my changes before submitting, so I don't feel particularly motivated to do so.

This is by no means a knock against the maintainer/author -- this repo became very popular, especially for a small command-line utility, and I can imagine it would be hard to manage.

from git-standup.

kamranahmedse avatar kamranahmedse commented on May 30, 2024

Hey @dgarrick, sorry, I understand your concern!

Actually, I am not getting much time these days. Will try to clean up the PRs by this coming weekend. Thanks for the reminder :)

from git-standup.

dgarrick avatar dgarrick commented on May 30, 2024

@kamranahmedse no worries! Thanks for putting this tool out in the open. I'll try to submit my PR once I get a little time as well 👍

from git-standup.

kamranahmedse avatar kamranahmedse commented on May 30, 2024

Fixed in #86. Thanks guys

from git-standup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.