Git Product home page Git Product logo

Comments (11)

pjfanning avatar pjfanning commented on August 11, 2024

Pekko 1.1.0-M1 is released. It is a milestone release but the jars are all up on Maven Central.

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

#1354 PR experiment does not seem to pick up this issue. Could be a gap in test coverage. @TjarkoG could you see if you could add a unit test that reproduces this?

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

There are some changes in the Pekko dispatch code in v1.1.0-M1. I wouldn't have thought them major.

https://github.com/apache/pekko/commits/0930982b9a5625e622c4c4c2a6f71dc9917cb336/actor/src/main/scala/org/apache/pekko/dispatch

apache/pekko#485 is the biggest change

from kamon.

TjarkoG avatar TjarkoG commented on August 11, 2024

@pjfanning sry for the late response.
I've looked into it but the whole instrumentation logic is sadly out of my knowledge zone.
Took me way longer to gather the information i put above than im proud to admit :(

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

The strange thing is the #1354 CI tests pass for pekko. Any interest in just building your own kamon jars using the branch underlying #1354 ?

from kamon.

TjarkoG avatar TjarkoG commented on August 11, 2024

i can try if this would help with our problem but im not to optimistic that it will help.
the problems with the "normal" jars are also only occurring when starting with the kanela-agent for instrumentation and when using the dispatcher "pekko.io.pinned-dispatcher" from the reference.conf "pekko.io.tcp"
edit:
i've build the jar locally based on #1354 and tried it with the same result

from kamon.

TjarkoG avatar TjarkoG commented on August 11, 2024

@ivantopo do you have any idea how to create tests for that?

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

I created https://github.com/pjfanning/kamon-pekko-http-test based on the description here and this runs fine with no issues.

from kamon.

TjarkoG avatar TjarkoG commented on August 11, 2024

Did you start it with the kanela java-agent?
Without it does work but we dont get the instrumentation

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

Did you start it with the kanela java-agent? Without it does work but we don't get the instrumentation

Thanks. I hadn't added kanela-agent. The issue happens with it enabled. I updated the sample project. I haven't used Kamon since its early days. I have my own fork that I use myself and it works with Pekko 1.1 (https://github.com/pjfanning/micrometer-pekko).

from kamon.

pjfanning avatar pjfanning commented on August 11, 2024

I may have messed up the test run but when I tried Scala 3.3.3 and 2.12.19, it seemed ok. Maybe this only happens with Scala 2.13.

from kamon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.