Git Product home page Git Product logo

Comments (3)

Kamirus avatar Kamirus commented on July 22, 2024

Yes, that would be nice to have, but it's a bit problematic right now as it requires quite a bit of work.
I don't have enough time to implement it myself, but I can at least describe how I see it, and maybe someone would want to tackle it on their own.

  • Table is backend agnostic so I wouldn't mix it with codecs
  • These type classes are only used for executing queries (functions like query, insert, etc.) and not building queries (where Table is concerned - this sort of restricts the number of files that need changes) with the only exception being lit (also litPG and litSQLite3)
  • it's already easy to make a version of lit that uses codecs instead of type class overloading, the following function is the backbone of both litPG and litSQLite3
litUnsafeFromForeign   col s a. Coerce col  Foreign  col s a
litUnsafeFromForeign = unsafeFromCol <<< Col <<< EForeign

The purpose of codecs or these ad-hoc type classes is to encode/decode records that represent rows in a database.
One record is encoded as Array Foreign.

The first problem to tackle is to expose low-level, unsafe API in the postgresql-client as the currently exported functions require these ad-hoc type classes anyway.
It would allow us to pass/get Foreign values to/from pg-client and handle conversion on our own.
For now we could work around that as ToSQLRow accepts Array Foreign (it's already utilized to simplify the implementation of insert_ but not insert nor query because of the following problem), but the problem is that FromSQLRow does not have an instance for Array Foreign so we have to operate on a typed representation which requires more type-level programming.
We need either of the following solutions:

The second step would be to implement a generic query operation that uses codecs

  • I'd start by simplifying genericQueryPG:
    instance genericQueryPG
    ( ColsToPGHandler B i tup o
    , GetCols i
    , FromSQLRow tup
    , MonadSeldaPG m
    ) ⇒
    GenericQuery BackendPGClass m i o where
    genericQuery _ q = do
    let
    (Tuple res _) = runFullQuery q
    { strQuery, params } = showPG $ showQuery q
    rows ← pgQuery (PostgreSQL.Query strQuery) params
    pure $ map (colsToPGHandler (Proxy Proxy BackendPGClass) res) rows
    by using the unsafeQuery in the pgQuery to return foreigns instead of typed rows thus dropping ColsToPGHandler entirely (look at genericQuerySQLite3 for inspiration)

In case anyone would want to implement feel free to ask about any details or questions

from purescript-selda.

JordanMartinez avatar JordanMartinez commented on July 22, 2024

Rather than export unsafeQuery directly as is, couldn't there be other versions of the other functions there (e.g. query) that drop the ToSQLRow and FromSQLRow type class constraints?

from purescript-selda.

Kamirus avatar Kamirus commented on July 22, 2024

I think so, yes

from purescript-selda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.