Git Product home page Git Product logo

Comments (15)

kamilchm avatar kamilchm commented on May 26, 2024

What's the working directory?

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

I used this: https://github.com/kamilchm/go2nix#example-leaps, so I cd into src/github.com/bakape/meguca (the package I was attempting to save) and used go2nix save.

from go2nix.

kamilchm avatar kamilchm commented on May 26, 2024

Is src/github.com/bakape/meguca inside /run/user/1000/tmp.pY8OMnWUi5/ (the $GOPATH)?
Did you run go build in src/github.com/bakape/meguca before go2nix save?

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

Indirectly, yes.
https://github.com/bakape/meguca/blob/master/Makefile#L29

/run/user/1000/tmp.pY8OMnWUi5/ is in fact the $GOPATH.

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

Is src/github.com/bakape/meguca inside /run/user/1000/tmp.pY8OMnWUi5/ (the $GOPATH)?

Misread, the answer is no, /run/user/1000/tmp.pY8OMnWUi5/ is the $GOPATH, however the makefile may modify it.

Edit: ...or not, that's old behavior, makefile shouldn't be messing it up.

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

Right, I had forgotten.
The same thing will happen with hydron.

from go2nix.

kamilchm avatar kamilchm commented on May 26, 2024

go2nix requires the package you save and all its dependencies to reside inside the GOPATH

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

As far as I'm aware, that is the case, and this used to work in the past, but I believe @bakape changed to go modules and is requiring the v2 branch of thumbnailer now instead of master.

from go2nix.

kamilchm avatar kamilchm commented on May 26, 2024

Seeing the go.mod in the repo I would suggest to try the new https://nixos.org/nixpkgs/manual/#ssec-go-modules or https://github.com/adisbladis/vgo2nix

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

For the first link, can I assume that means I could just convert the entire meguca derivation to buildGoModule, or is it something else? Also thank you for referring me to those two links.

from go2nix.

kamilchm avatar kamilchm commented on May 26, 2024

Converting the meguca derivation would be a move in the right direction, although I'm not sure if there's no corner cases in maguca not handled in buildGoModule.

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

Well I think I have enough information to fix this now.
Is this something planned to be implemented or fixed in this project, or should the issue be closed?

from go2nix.

kamilchm avatar kamilchm commented on May 26, 2024

This project will not support go modules in any way so I would close it.

from go2nix.

Chiiruno avatar Chiiruno commented on May 26, 2024

Thank you for the help.

from go2nix.

bakape avatar bakape commented on May 26, 2024

@Chiiruno
I'm still using the master branch of thumbnailer. The difference is master being properly marked as the v2 branch now as required by the Go module system.

from go2nix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.