Comments (6)
BenjaminCCross
commented on June 27, 2024
1
What should be in this contributing document? One big thing I can think of is this.
- When making a pull request, reference a specific issue. If there is no specific issue then make one. This will allows to keep track of issues as well as see growth and change.
from bookomatic.
AlbertCoolGuy
commented on June 27, 2024
That sounds good but I also thought like guidelines for making a pull
request.
…On Fri, 20 Mar 2020, 15:32 Benjamin Cross, ***@***.***> wrote:
What should be in this contributing document? One big thing I can think of
is this.
- When making a pull request, reference a specific issue. If there is
no specific issue then make one. This will allows to keep track of issues
as well as see growth and change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJOQ33GNCPUQSYPGTWDVFVLRIN47TANCNFSM4LQM2BHA>
.
from bookomatic.
BenjaminCCross
commented on June 27, 2024
Here are some useful tips: link.
More specific ideas:
- When making a pull request include the number of the issue in the title.
- Use clear and succinct commit messages. Useful but long guide: link
- Keep your pull request to one issue. Smaller is better.
- When describing the bull request don't assume past history with the issue.
- If you need help please include areas of concern to help reviewers know what they can do.
- add screen shots if you are including visual changes
- @mention devs that you specifically want to see the PR and mention why. Such as having experience with the issue.
Suggestions? Also ideas on other forms of contribution ie documentation, issue gardening etc.?
from bookomatic.
AlbertCoolGuy
commented on June 27, 2024
Could you make a pull request with a contributing file?
…On Fri, 20 Mar 2020, 16:03 Benjamin Cross, ***@***.***> wrote:
Here are some useful tips: link
<https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests>
.
More specific ideas:
- When making a pull request include the number of the issue in the
title.
- Use clear and succinct commit messages. Useful but long guide: link
<https://chris.beams.io/posts/git-commit/>
- Keep your pull request to one issue. Smaller is better.
- When describing the bull request don't assume past history with the
issue.
- If you need help please include areas of concern to help reviewers
know what they can do.
- add screen shots if you are including visual changes
- @mention devs that you specifically want to see the PR and mention
why. Such as having experience with the issue.
Suggestions? Also ideas on other forms of contribution ie documentation,
issue gardening etc.?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJOQ33BKDAFPYOQFIVQHUNDRIOAU3ANCNFSM4LQM2BHA>
.
from bookomatic.
BenjaminCCross
commented on June 27, 2024
Yeah absolutely. Though now I am concerned it won't be up to par...
from bookomatic.
BenjaminCCross
commented on June 27, 2024
@AlbertCoolGuy @KalleHallden this issue can be closed after the merge. I can't close it for some reason, but as admin or the person who opened it one of you can.
from bookomatic.
Related Issues (20)
- Progressive WebApp. HOT 5
- Creation of Django Apps HOT 2
- Grammatical mistake
- Code of conduct HOT 2
- Feature
- should support 2FA (Physical and app)
- [Enchancement] Add Github Action "Django" to repository HOT 2
- Fetch events from other calendars HOT 2
- Browser ad-on? HOT 2
- What about real front-end??? HOT 1
- Slack/IRC/Something else? HOT 6
- Rename HowToContribute.md to CONTRIBUTING.md HOT 4
- Add issue and pull request template to repo.
- Virtual Development/Deployment Environments with Vagrant/Ansible HOT 1
- django error - page not found at / HOT 2
- Can't display homepage (index.html) HOT 2
- Frontend HOT 1
- Is this project still alive? HOT 13
- Problem while installing requirements.txt
- I think project is dead by now. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bookomatic.