Expect to throw a `TypeError` got failed, `actual: TypeError, expected: TypeError` about kahlan HOT 4 CLOSED

Is it actually expected behavior?

Well, as you can see, PHP prefixes error messages with the "callable context" for throwed TypeError, so "Kahlan\Cli\Kahlan::{closure}():" is something added by PHP itself.

<?php
namespace Simple\Test;
use DateTime;
use Throwable;

function test(DateTime $datetime) {}

try {
    test(null);
} catch (Throwable $e) {
    echo $e->getMessage(); // Simple\Test\test(): Argument #1 ($datetime) must be of type DateTime, null given, called in [...][...] on line 11
}

I'd expect the test should give me something like this if the test was failed.

Indeed, I fixed it in the 5.1.1 release.

from kahlan.

When you define a specific error message to an Exception it must matches the throwed one.
What make you feel there's an issue here ?

from kahlan.

it must matches the throwed one
@jails exactly! but, as we can see the error message was

message:`TypeError` Code(0) with message "Kahlan\\Cli\\Kahlan::{closure}(): ...."

It seems like it was thrown from a closure inside Kahlan\Cli\Kahlan namespace instead of the test file, which doesn't have namespace.

Is it actually expected behavior?

from kahlan.

Also the failed message doesn't show the complete error message, or I could say it less informative.

actual:
  (object) an instance of `TypeError`
expected:
  (object) an instance of `TypeError`

To me, it sounds like "Hey, go have a test failed. You expecting an instance of TypeError, but you got an instance of TypeError". What's make it failed?

I hope it could be more informative, or at least it should behave like any other tests using toThrow(). e.g. I have a test as follow

expect(function () {
    // ...
})->toThrow(new SomeException('Some expected message'));

I'd expect the test should give me something like this if the test was failed.

It expect actual to throw a compatible exception.

actual:
  (object) an instance of `SomeException` Code(0) with message "Some actual message"
expected:
  (object) an instance of `SomeException` Code(0) with message "Some expected message"

So I can easily understand what's missing and what's makes my test failed,

from kahlan.