Some Lua errors when using the script about redis-wireshark HOT 6 CLOSED

What version of Lua are you using?
On 27 Mar 2013 14:37, "NanXiao" [email protected] wrote:

Hi, John:

I have used your script, but it seems not work well. There are some erros I have encountered:

Lua Error: d:\Program Files\Wireshark\redis.lua:52: attempt to index local 'submatch' (a nil value)
Lua Error: d:\Program Files\Wireshark\redis.lua:33: attempt to index local 'line' (a nil value).

I am not very familiar with Lua, so I can't find out the root cause. Could you help to check it? Thanks very much in advance!

Best Regards
Nan Xiao

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

from redis-wireshark.

Lua 5.1, thanks!

from redis-wireshark.

Hi, John:

Glad to receive your response!

The attachment are two wireshark capture packages: One is parsed normally while the other is some error occured.
I find if the Redis data in one TCP segment, the dissector can parse normally. While if the Redis data occupies one more TCP segments(such as INFO command response), the dissector can't parse normally.

Could you help to check it? Thanks very much in advance!

Best Regards
Nan Xiao

At 2013-03-27 17:24:39,"John Zwinck" [email protected] wrote:
What version of Lua are you using?
On 27 Mar 2013 14:37, "NanXiao" [email protected] wrote:

Hi, John:

I have used your script, but it seems not work well. There are some erros I have encountered:

Lua Error: d:\Program Files\Wireshark\redis.lua:52: attempt to index local 'submatch' (a nil value)
Lua Error: d:\Program Files\Wireshark\redis.lua:33: attempt to index local 'line' (a nil value).

I am not very familiar with Lua, so I can't find out the root cause. Could you help to check it? Thanks very much in advance!

Best Regards
Nan Xiao

¡ª
Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

¡ª
Reply to this email directly or view it on GitHub.

from redis-wireshark.

This is probably a real issue for exactly the reason you surmise: my code doesn't do anything special for Redis messages fragmented by TCP. Patches welcome.

I'd also like to leave a link to the StackOverflow question you posted about this, just for reference: http://stackoverflow.com/questions/15630725/is-there-any-good-redis-dissector-for-wireshark

from redis-wireshark.

@jzwinck You can also close this issue. It's fixed by my PR #6

from redis-wireshark.

Thanks @johnzeng for #6.

from redis-wireshark.