Git Product home page Git Product logo

Comments (9)

pruthvirajkarur avatar pruthvirajkarur commented on July 21, 2024

Even i am facing the same issue and its only for IOS.

from react-native-tag-input.

nol13 avatar nol13 commented on July 21, 2024

Which version of RN? >= 0.54?

Dupe of this? #55

from react-native-tag-input.

thatjuan avatar thatjuan commented on July 21, 2024

0.55 on iOS.

from react-native-tag-input.

nol13 avatar nol13 commented on July 21, 2024

There is a bug in recent versions of RN where Backspace gets called incorrectly when the TextInput is cleared, so it doesn't return in the 'if' check below and then gets pop'd. And I think another bug where the value wasn't getting set right.

if (this.props.text !== '' || event.nativeEvent.key !== 'Backspace') {
      return;
}
const tags = [...this.props.value];
tags.pop();

There are PR's up that fix it, but who knows when it'll make it out to release. Have a branch off of 0.55.4 with the 2 patches applied that fixed the issues for me, if useful to anyone.

https://github.com/nol13/react-native/tree/TextInput-Patch-0.55.4

from react-native-tag-input.

Ashoat avatar Ashoat commented on July 21, 2024

Thanks for researching this bug @nol13! It looks like there are two issues, yeah?

  • Backspace issue, fixed by this PR. Am trying to bother the right people to see if we can merge that one.
  • Text filtering for Chinese and other languages are broken, fixed by either this PR, or this PR. I would like to get some clarity on which of these should be merged.

from react-native-tag-input.

nol13 avatar nol13 commented on July 21, 2024

Ya two issues, need both patches to get normal behavior. Not really sure of/qualified to speak about the relative merit of 19087 vs. 18456, as far as I can tell both work, just need one or the other.

The backspace patch is needed to fix the issue where you can only add one tag. The other fixes a bunch of weird behavior where the js and native values can get out of sync or something after adding a few tags, and events stop firing, backspace will delete tags even if there is still text, etc.

from react-native-tag-input.

maharjanaman avatar maharjanaman commented on July 21, 2024

@nol13 any workaround for expo users?

from react-native-tag-input.

nol13 avatar nol13 commented on July 21, 2024

i think downgrading to expo 25 would do it, if that's a possibility.

(and saw backspace fix merged, thanks for moving that along!)

Edit: is fixed in 0.57 in case anyone comes across this still

from react-native-tag-input.

LaurieWilliamsNZ avatar LaurieWilliamsNZ commented on July 21, 2024

Expo 25 is deprecated. Still getting this issue in the latest version of expo.

from react-native-tag-input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.