cmake include_directories: /usr/include breaks cross-build about dab-cmdline HOT 5 CLOSED

On Wed, Jun 5, 2019, 8:28 PM borine ***@***.***> wrote: Many thanks for developing and sharing this great software. It works well for me, but there is one irritation with the cmake configuration files that means I always have to patch them before I can build. Is there a specific reason why many of the CMakeLists.txt files in this project explicitly add /usr/include to the "include_directories" ? I ask because this breaks cross-compilation, causing the cross compiler to look in the build system's native /usr/include folder before the desired sysroot /usr/include. I can't imagine there is any sane c++ toolchain that does not automatically search for system header files in /usr/include, so my preferred fix is to just delete that line from all CMakeLists.txt files. If there is some obscure reason why dab-cmdline really does need to explicitly tell the compiler to search /usr/include, then can I ask that the line be edited to "=/usr/include" as that would tell the compiler to use the correct sysroot? I can prepare a pull request with either of the above 2 changes if you are happy to accept either of them. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=ACCPHQEISENU23E5TB54MGLPZAAVVA5CNFSM4HUC2VTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GX25LCA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCPHQDEUVLBRBMCUNJSTMDPZAAVVANCNFSM4HUC2VTA> .

I haven't used this project for a while now, but a quick look at the sources shows that CMakeLists.txt in several directories does still have /usr/include in the include_directories list. So no, there has been no progress. The fix is just to delete that entry from all include_directories lists - but I guess no-one else has reported any problems with this, so perhaps its only my build environment that fails. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCPHQDLWBTKBUKNHQE22M3TOSUK3ANCNFSM4HUC2VTA> .