[BUG] Cannot import from "above" the executed file about jayvee HOT 10 CLOSED

Yeah, totally fine I think. I wasn't trying to argue for how a fix might look, more for a long term direction.

from jayvee.

How is the behavior if you execute the file from one level above? E.g. jv src/mainModel.jv?

from jayvee.

Sadly, the issue persists.

from jayvee.

Traced it back to this line of code:

I think we'd have to pass the working directory as an argument instead of assuming that the referenced file is at the root level of the working dir.

Still, a design decision we have to make @rhazn @joluj: Do we want to prevent imports from anywhere above (i) the main file or (ii) the dir where the cli was called for security reasons?

from jayvee.

I wouldn't care and just allow dir traversal freely, I doubt there is much of a security issue there.

from jayvee.

I'd vote for (ii).
I expect that the following monorepo-like folder structure will be used which is not possible with (i):

├──  libs
│  └──  a.jv
│  └──  b.jv
└──  apps
   └── cool-app-1.jv
   └── cool-app-2.jv

from jayvee.

I think ii is not very nice because it will make programs behave differently depending on the working dir of the interpreter. That is confusing in Python and I'd prefer not to introduce it in JV.

from jayvee.

Ah true, then I'd vote for your initial idea of allowing dir traversal freely 👍

from jayvee.

From a technical point of view, it is difficult not to restrict directory traversal - at least with our current implementation.

The JayveeWorkspaceManager needs to be initialized with all the workspaces we want the language-server to be aware of. Passing the machine's root is probably not a good idea performance-wise.

That means we'd have to evaluate how to dynamically add (and remove) documents to the WorkspaceManager, depending on where imports point to. This is a larger refactoring, IMO. I'm not sure how well-supported that would be with Langium, but I assume there would be a way.

In conclusion, we should create a feature ticket, IMO, as it exceeds the scope of a bug fix by far and introduces new behavior (having a predefined workspace has been the intended behavior so far).
Besides, we should implement a fix for this ticket that allows (ii) traversing up until the dir is reached where jv was executed from.

from jayvee.

Perfect! Created #593 for a better long-term solution and will soon push a quick-fix for the bug.

from jayvee.