Git Product home page Git Product logo

Comments (3)

malcolmsparks avatar malcolmsparks commented on June 22, 2024

If malformed? doesn't require properties to function, then you're right. We want malformed? to be processed as soon as possible, because a bad request should be thrown out as soon as possible, and not involved a database lookup.

I've checked all my resources, and none emit :parameters in the request version (although some emit :parameters in the 'static' non-request version) While I wanted to keep rules about which property can and can't be emitted in either version to a minimum, your case for bringing malformed? forward in the interceptor chain is compelling and I accept your argument - thanks for being so clear.

Perhaps malformed? is also poorly named. Maybe parse-parameters would be better. Of course, if those parameters end up being bad, and uncoerceably so, we send a 400 (Client Error). The name is historic, via Liberator, so it's not essential we keep it. What do you think?

from yada.

stijnopheide avatar stijnopheide commented on June 22, 2024

Yes I think that would be a good change. The name comes from the spec I guess.

10.4.1 400 Bad Request
The request could not be understood by the server due to malformed syntax.

from yada.

malcolmsparks avatar malcolmsparks commented on June 22, 2024

Closed since recent commits

from yada.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.