Return body from PUT or POST about yada HOT 9 CLOSED

Yes, after consideration I think yada should support returning a body in PUT/POST as per the lines of the spec. Let's keep this issue open.

from yada.

Hi guys!
Do we have some shortcut for having body in PUT until proper impl and release?
I'm trying this with no lucky

(defrecord MyRecordType [d])

(extend-protocol PutResult
  MyRecordType
  (interpret-put-result [o ctx]
    (assoc-in ctx [:response :body] (:d o))))

from yada.

PUT bodies should work - see the phonebook example. Or do you mean
response bodies?

On 8 March 2016 at 10:35, tangrammer [email protected] wrote:

Hi guys!
Do we have some shortcut for having body in PUT until proper impl and
release?
I'm trying this with no lucky

—
Reply to this email directly or view it on GitHub
#26 (comment).

from yada.

sorry, I meant response bodies :)

from yada.

Thanks Malcolm!
could i ask you to do a release including this commit?
BTW: I tried to find tag xxxx-32 to work on top of it but i couldn't find it

from yada.

Yes... but my tests fail :(

But give me a couple of hours...
On 8 Mar 2016 13:57, "tangrammer" [email protected] wrote:

Thanks Malcolm!
could i ask you to do a release including this commit?
BTW: I tried to find tag xxxx-32 to work on top of it but i couldn't find
it

—
Reply to this email directly or view it on GitHub
#26 (comment).

from yada.

👍 👍

from yada.

Hi,

You can do this by returning a modified response, which yada's method proxy
interprets that you want to control what is returned.

(testing "return response"
(let [h (yada (resource {:methods {:put {:response (fn [ctx](assoc
%28:response ctx%29 :body))}}}))
response (h (request :put "/"))](is %28= "BODY" %28b/to-string %28:body @response))))))

I've had to back out the last commit because it broke some test, but I've
added the above test which passes.

Regards,

Malcolm

JUXT LTD.
Software Consulting, Delivery, Training

On 8 March 2016 at 14:59, tangrammer [email protected] wrote:

[image: 👍] [image: 👍]

—
Reply to this email directly or view it on GitHub
#26 (comment).

from yada.

Thanks for the solution :)

I had to change the status to 200 in order to have aleph (or the yada handler?) actually serving the body. (with status 204, the body is not send, although the header contains a correct content length). To reflect that, I prepared a PR with the corresponding change in the test.

Pull Request: #72

from yada.