Git Product home page Git Product logo

Comments (16)

JustinTulloss avatar JustinTulloss commented on August 17, 2024

Patches welcome ;).

Next time I have time I'll look into how much effort this would require.

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

+1 :)

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

Looks like the Datasift guys have already patched zeromq.node to support 0mq 3.0. https://github.com/datasift/zeromq.node

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

Ok I forked the Datasift repo and incorporated some changes made to zmq via TJ. Now you can install from npm by doing sudo npm install zmq-3.0.

from zeromq.node.

tj avatar tj commented on August 17, 2024

maybe @JustinTulloss could give a few of us commit access so we can keep things up to date, not sure how active this project is

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

@visionmedia Agree. I don't like cluttering NPM with unnecessary forks.

from zeromq.node.

ollieparsley avatar ollieparsley commented on August 17, 2024

Just FYI, the forked DataSift repo was done for zmq 3.0 support and has been used in our production HTTP and Websocket streaming service for a few months now and we've had no issues so far. It was a quick fix because at the time we were moving up to tens of thousands of messages (multiple times the size of the Twitter firehose) a second and zmq 3.0 did proper server-end filtering (zmq 2.0 sent all messages and filtered at the client end) of topics which reduced our internal network traffic a lot. We've not used all the different socket types, only pull/push and pub/sub.

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

@ollieparsley Yes and coincidentally we are using only push/pull and pub/sub too :) Needed pub side filtering and hence this fork. Thanks!

from zeromq.node.

JustinTulloss avatar JustinTulloss commented on August 17, 2024

I would also like to avoid forking unnecessarily, but as I'm sure you've noticed I haven't spent much time on this project lately. @visionmedia, @shripadk are you both interested in having commit access?

from zeromq.node.

JustinTulloss avatar JustinTulloss commented on August 17, 2024

Also @ollieparsley, is your fork backwards compatible?

from zeromq.node.

tj avatar tj commented on August 17, 2024

@JustinTulloss yup that would be great! Agreed with the forking

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

@JustinTulloss Great :)

from zeromq.node.

JustinTulloss avatar JustinTulloss commented on August 17, 2024

Ok, you're both added.

from zeromq.node.

tj avatar tj commented on August 17, 2024

wicked thanks man

from zeromq.node.

shripadk avatar shripadk commented on August 17, 2024

awesome :)

from zeromq.node.

ronkorving avatar ronkorving commented on August 17, 2024

Closing this, as we're 3.0 compatible.

from zeromq.node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.