Git Product home page Git Product logo

Comments (2)

justinmeza avatar justinmeza commented on July 20, 2024

Ah, good catch! This is indeed a bug that's been there for awhile. Basically, it happens because copying values in lci (as is done with "FIFTY R NNN") does not actually copy the value of NNN to FIFTY, but just increments a reference count to the same value as NNN and then has FIFTY reference the same value. (This is an efficiency hack to prevent lots of data movement -- copies are just an addition operation. When references go to 0 then the data is never used again and can safely be free'd.)

This behavior is correct and works fine for interpreted code, but the problem is that interpreter code that directly modifies the data stored in values (which I think only appears in for statements -- though I cannot recall if this is definitely the case) also modifies the value of any other references (as is done here https://github.com/justinmeza/lci/blob/master/interpreter.c#L3476-L3479).

The fix is to create a new value when updating the loop induction variable so after NNN is updated, FIFTY will reference a value with data 50 and NNN will reference an new value with data 51. I'll push a fix to master and future.

from lci.

justinmeza avatar justinmeza commented on July 20, 2024

OK, fix pushed. Closing this issue!

from lci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.