Comments (5)
JustFly1984
commented on August 15, 2024
@uriklar I do not really need those separate options. If you remove them, we will totally branch out of original react-google-maps without any backward compatibility. I'm personally don't care much. single prop is better than many.
On other side passing an object to the prop is bad for performance. If you pass options object generated in runtime, it is bad for performance anyway. So less props, less headaches for everybody. We already get rid of default prefixed props anyway.
from react-google-maps-api.
uriklar
commented on August 15, 2024
Good points! I actually think backwards compatibility with react-google-maps is pretty crucial if we want people to be able to migrate easily. And also the performance point is a good one.
I think those two are good enough points to drop this proposal.. We'll have a one time effort to write the type annotations correctly and then it will be behind us.
from react-google-maps-api.
JustFly1984
commented on August 15, 2024
Looks good!
from react-google-maps-api.
JustFly1984
commented on August 15, 2024
can we close this issue?
from react-google-maps-api.
JustFly1984
commented on August 15, 2024
reopen if needed
from react-google-maps-api.
Related Issues (20)
- Doc site not working HOT 1
- Right click doesn't work in InfoBox component HOT 2
- Loading google maps JS API HOT 7
- This page can't load Google Maps correctly. For developmental purposes only.
- Docs link broken HOT 3
- Marker will be discontinued on February 21, 2024. Please use google.maps.marker.AdvancedMarkerElement instead. For more information about the end of support, please visit https://developers.google.com/maps/deprecations. HOT 14
- Marker Icon Misalignment with Custom SVG Path in @react-google-maps/api
- 21st, 2024, google.maps.Marker is deprecated. HOT 7
- Docs website seems to be down HOT 5
- documentation website become gambling ads HOT 1
- README netlify link is showing scam games HOT 1
- Strange behavior of the information window HOT 2
- Can not obtain the paths from the <Polygon> component. HOT 1
- DoubleClick is not working when mouseup event call
- Autocomplete results show after enter N(number) character
- Update Dependencie @types/google.maps HOT 3
- MarkerF icon hover
- setEditable: not a LatLng or LatLngLiteral: in property lat: not a number
- Page on netlify is broken, can't see docs HOT 1
- @react-google-maps/api in this package i need to send the session token in autocomplete but it will not be have any other props HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-google-maps-api.