Git Product home page Git Product logo

Comments (15)

JustFly1984 avatar JustFly1984 commented on August 15, 2024

@urikphytech welcome onboard

from react-google-maps-api.

urikphytech avatar urikphytech commented on August 15, 2024

@JustFly1984 Thanks! I prefer using my personal account for OSS. Can you invite @uriklar to be a collaborator instead of this account? Thanks!

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

@uriklar done

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

@uriklar so in this case just don't commit your google API key), and lets coordinate features we are working on.

from react-google-maps-api.

uriklar avatar uriklar commented on August 15, 2024

Thanks! @JustFly1984 I sent you an invite on google hangouts. We can chat there. I'd be happy to have a chat about roadmap, open issues etc...

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

There is components left to refactor to new API

LoadScript - done
GoogleMapProvider - done
GoogleMap -done
TrafficLayer - done
BicyclingLayer - almost done, there is a bug, which errors out onload.

Circle - not done
Marker - not done
Polyline - not done
Polygon - not done
Rectangle - not done
InfoWindow - not done
OverlayView - not done
DirectionsRenderer - not done
FusionTablesLayer - not done
KmlLayer - not done
StreetViewPanorama - not done

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

Now I will continue with
OverlayView
DirectionsRenderer
FusionTablesLayer
KmlLayer

from react-google-maps-api.

uriklar avatar uriklar commented on August 15, 2024

Ok, so i'll take shape components:
Polyline
Polygon
Rectangle
Circle

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

Thanx
Them you do examples, just add one more < GoogleMapProvider /> to index.js, and you can comment out first 2 temporary, so it does not heat up your CPU

from react-google-maps-api.

uriklar avatar uriklar commented on August 15, 2024

@JustFly1984 I see that you're creating the google maps instances in the constructor. This will create a bug when using StrictMode (and later on ConcurrentMode)
See this issue I opened on react-google-maps, it's explained in details there by alexrussel:
tomchentw/react-google-maps#921

The solution is to create the component instance in cDM. The downside of this is that you then have to call setState in cDM... Maybe you can think of a better solution for this.

from react-google-maps-api.

uriklar avatar uriklar commented on August 15, 2024

@JustFly1984 also, can you give me a brief explanation as to why you are using the prevProps in derived state? What use case does it solve for you?

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

@uriklar Ok, so I've read all of this) and here is my thoughts - lets finish up current implementation first,
And after that you can create separate example with StrictMode and test it out. Currently I have made a lot of changes to original API, so it could fix itself, or not. I'm pretty sure I'll find the way to handle this issue.

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

A little off topic: What do you think about switching the bundler from webpack to rollup? if there any benefits? I want to support as many platforms as possible

from react-google-maps-api.

JustFly1984 avatar JustFly1984 commented on August 15, 2024

Current progress:

LoadScript - done
GoogleMap -done
TrafficLayer - done
BicyclingLayer - done

Circle - done
Marker - add support for MarkerCluster
Polyline - done
Polygon - done
Rectangle - done
InfoWindow - done
OverlayView - done
DirectionsRenderer - done
FusionTablesLayer - not done
KmlLayer - ?
StreetViewPanorama - not done

addons: do we really need it?

from react-google-maps-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.