Comments (13)
That would be amazing, in the meantime if I figure out anything more I'll let you know 😃
from httpclient-interception.
Pulled it down and can confirm this has fixed it 😄 Nice one
from httpclient-interception.
Yay, breaking changes are fun! 😭
from httpclient-interception.
This is particularly weird as we're happily using 12.0.2 internally in our apps' tests.
from httpclient-interception.
Though we're not using the overload that takes a JsonSerializerSettings
.
from httpclient-interception.
Also, I've not tried it on windows with Full Framework, it might be a mono only quirk, not sure yet.
Edit: Works on netcoreapp2.x
from httpclient-interception.
Actually we are using that overload, it's just that it's an optional parameter:
from httpclient-interception.
If this is a blocker it'll have to wait until .NET Core 3.0 ships in September, because then we can ship a 3.0.0 of this as a breaking change and remove the dependency on Netwonsoft.Json
to give people the option to use System.Text.Json
instead.
(And it would be tidier to ship a 3.0 to go with 3.0 😄)
from httpclient-interception.
I ideally need a fix soonish, my workaround would be running this on core, but we want mono cause it's the closest thing to xamarin iOS/Android which is our target platform.
That exception tells me it can't find WithJsonContent
, so I don't get why the version of newtonsoft has anything to do with it, surely the exception message is wrong and it means some other method?
from httpclient-interception.
Yeah, it's a weird one. Something about optional parameters and/or a change somewhere in 12.x with JsonSerializerSettings
?
from httpclient-interception.
I'd be happy to look at doing a beta of a 3.0.0 with changes to decouple Newtonsoft.Json in the soon-ish future (within a week?) and pushing it to NuGet to unblock you though.
from httpclient-interception.
I'll see if I can pick up the above this week.
from httpclient-interception.
See #127 for a fix candidate.
from httpclient-interception.
Related Issues (20)
- Add ability to add multiple hosts HOT 15
- Allow access to CancellationToken HOT 2
- Support for intercepting all requests sent to HttpClient HOT 14
- Question: How to simulate a timeout/no response from downstream service HOT 2
- request: more examples for response changing based on how many times called so far HOT 4
- Improve custom matching HOT 3
- NullReferenceException when Deregister builder with a custom matcher HOT 2
- Verify calls to the registered end points have been called [discussion] HOT 8
- Same request but with different responses HOT 4
- Add [StringSyntax] attributes HOT 2
- Remove Newtonsoft.Json
- Async RegisterBundle() overloads
- WithResponseHeaders and WithContentHeaders overloads HOT 7
- Fix remote certificate is invalid for https HOT 3
- Response sequence HOT 1
- Add exception list for urls to ignore when ThrowOnMissingRegistration is true
- Question: Should HttpClient created from HttpClientInterceptorOptions auto-follow redirects? HOT 1
- ILogger<T> Integration? HOT 1
- Update README for bundles
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpclient-interception.