Git Product home page Git Product logo

Comments (5)

JustCarmen avatar JustCarmen commented on July 24, 2024

Are these default webtrees icons? I cannot find them. Where are these icons located? Are you sure they are not part of a custom module?

Give me a link to a page where I can see them so I can find out where they came from.

from webtrees-theme-justlight.

heiler avatar heiler commented on July 24, 2024

Here is an example
https://www.heiler-ahnen.de/webtrees/tree/heiler/individual/I0160/Theodor-Heiler#
You can find the graphics in Clouds, Colors, Webtrees and Xenea.

from webtrees-theme-justlight.

ric2016 avatar ric2016 commented on July 24, 2024

Most of these icons are in fact added via custom modules.

How custom modules from different sources interact is fundamentally undefined. I think it makes more sense though for custom modules providing specific functionality (Gov4Webtrees in this case) to adapt to certain 'well-known' custom themes, rather than the other way around.

I have actually done this already in my custom modules - The additional icons used for the 'JustLight' theme match the ones used in the 'minimal' theme, as that seems to be the basis for the icons used in the 'JustLight' theme. So there is already a consistent look & feel.

@JustCarmen: If you decide to replace e.g. the map link icons as requested (this would affect the original Facts & Events tab), I'll adjust my custom modules accordingly.

from webtrees-theme-justlight.

JustCarmen avatar JustCarmen commented on July 24, 2024

I suspected these icons came from a custom module but I wasn't absolutely sure.

I think it makes more sense though for custom modules providing specific functionality (Gov4Webtrees in this case) to adapt to certain 'well-known' custom themes, rather than the other way around.

I agree. I've done the same thing within the Fancy imagebar module where I have provided the layout for the Rural theme (which is not mine).

Thanks @ric2016 for supporting the JustLight theme in your modules.

If you decide to replace e.g. the map link icons as requested (this would affect the original Facts & Events tab), I'll adjust my custom modules accordingly.

I don't think it is necessary since you've provided the support for this theme in your module. So I will close this issue.

from webtrees-theme-justlight.

heiler avatar heiler commented on July 24, 2024

But IMHO it is not nice and not functional.

from webtrees-theme-justlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.