Comments (3)
There's multiple problems here:
When disconnecting all the potential parents tasks get cancelled, but the cancellation is not awaited. Cancellation doesn't actually disconnect the connections already established
Next step is to disconnect all other distributed connections, perhaps we run into a problem here because the cancellation is not awaited. Either way the tasks are fire-and-forget which isn't recommended.
The reason that it's fire-and-forget is because the cancellation happens when we receive the message. If we need to await the cancellation and disconnecting we will temporarily block receiving messages from our parents if disconnecting takes a while
from aioslsk.
It is also rather odd that the connection remains open, or at least it appears that way.
from aioslsk.
Closing ticket, haven't seen this issue occur any more after the fixes referenced. If it comes back then the ticket can be re-opened or a new one created
from aioslsk.
Related Issues (20)
- Shares: Create large dataset for testing
- Transfers: Allow only 1 upload per user
- Transfers: lock transfer transitions
- Client: Make connecting optional during client start
- Messages: Investigate and describe server code 160 HOT 8
- Transfers: Local path not getting set on PeerTransferRequest message
- Network: timeout waiting for disconnect
- Help: AttributeError: 'SoulSeekClient' object has no attribute 'search'. HOT 2
- Unable to change my server port HOT 4
- Documentation: API references HOT 1
- Search: Limit amount of search results
- Transfer: download is queued when PeerTransferRequest is received even if it was removed HOT 1
- Transfer: reset local_path for transfers where the file is no longer shared HOT 3
- Shares: describe behaviour of slashes in query terms HOT 2
- Shares: allow configuration of different executors for scanning shares
- Shares: properly define behavior when attempting to add a directory that is already shared
- Shares: load_from_settings should remove directories that are no longer shared, update existing one's
- Users: add less convoluted way to add and remove friends
- Users: Tracking flags need to be removed when disconnected HOT 1
- Investigation usage of SQLite database
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aioslsk.