Git Product home page Git Product logo

Comments (3)

JurgenR avatar JurgenR commented on June 3, 2024

There's multiple problems here:

When disconnecting all the potential parents tasks get cancelled, but the cancellation is not awaited. Cancellation doesn't actually disconnect the connections already established

Next step is to disconnect all other distributed connections, perhaps we run into a problem here because the cancellation is not awaited. Either way the tasks are fire-and-forget which isn't recommended.

The reason that it's fire-and-forget is because the cancellation happens when we receive the message. If we need to await the cancellation and disconnecting we will temporarily block receiving messages from our parents if disconnecting takes a while

from aioslsk.

JurgenR avatar JurgenR commented on June 3, 2024

It is also rather odd that the connection remains open, or at least it appears that way.

from aioslsk.

JurgenR avatar JurgenR commented on June 3, 2024

Closing ticket, haven't seen this issue occur any more after the fixes referenced. If it comes back then the ticket can be re-opened or a new one created

from aioslsk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.