Git Product home page Git Product logo

Comments (5)

JurgenR avatar JurgenR commented on June 11, 2024

For the obfuscated flag bug, instead of starting the reader loop as soon as the connection state goes to CONNECTED the peer initialization message is now handled first, the connection gets modified and on then PeerConnection.set_connection_state with ESTABLISHED us called which now starts the reader loop.

from aioslsk.

JurgenR avatar JurgenR commented on June 11, 2024

PeerConnection was modified not to cancel the reader task and instead just to let the task run its course; the loop stops when the state of the connection goes to CLOSING/CLOSED. The task gets cleaned up after all disconnect tasks have been complete and messages still received during closing will be ignored.

from aioslsk.

JurgenR avatar JurgenR commented on June 11, 2024

Additionally the MR resolves another bug:

By default on login messages would be sent to notify the server that we have no parent but this isn't necessarily true if we just lost connection to the server (and not the parent) and reconnect.

Now a LoginEventSuccess is emitted by ServerManager and picked up by PeerManager which reports the correct messages to the server when login is successful by looking if we still have a parent

from aioslsk.

JurgenR avatar JurgenR commented on June 11, 2024

Refactored some of the message (de)serialization code. Which was necessary to handle exceptions when waiting for peer init message

from aioslsk.

JurgenR avatar JurgenR commented on June 11, 2024

It's fine for now, I did see an error where the ticket could not be found in the _expected_connection_futures and it was unclear why this happened (everything looked fine).

from aioslsk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.