Comments (5)
For the obfuscated
flag bug, instead of starting the reader loop as soon as the connection state goes to CONNECTED
the peer initialization message is now handled first, the connection gets modified and on then PeerConnection.set_connection_state
with ESTABLISHED
us called which now starts the reader loop.
from aioslsk.
PeerConnection
was modified not to cancel the reader task and instead just to let the task run its course; the loop stops when the state of the connection goes to CLOSING
/CLOSED
. The task gets cleaned up after all disconnect tasks have been complete and messages still received during closing will be ignored.
from aioslsk.
Additionally the MR resolves another bug:
By default on login messages would be sent to notify the server that we have no parent but this isn't necessarily true if we just lost connection to the server (and not the parent) and reconnect.
Now a LoginEventSuccess
is emitted by ServerManager
and picked up by PeerManager
which reports the correct messages to the server when login is successful by looking if we still have a parent
from aioslsk.
Refactored some of the message (de)serialization code. Which was necessary to handle exceptions when waiting for peer init message
from aioslsk.
It's fine for now, I did see an error where the ticket could not be found in the _expected_connection_futures
and it was unclear why this happened (everything looked fine).
from aioslsk.
Related Issues (20)
- Shares: Create large dataset for testing
- Transfers: Allow only 1 upload per user
- Transfers: lock transfer transitions
- Client: Make connecting optional during client start
- Messages: Investigate and describe server code 160 HOT 8
- Transfers: Local path not getting set on PeerTransferRequest message
- Network: timeout waiting for disconnect
- Help: AttributeError: 'SoulSeekClient' object has no attribute 'search'. HOT 2
- Unable to change my server port HOT 4
- Documentation: API references HOT 1
- Search: Limit amount of search results
- Transfer: download is queued when PeerTransferRequest is received even if it was removed HOT 1
- Transfer: reset local_path for transfers where the file is no longer shared HOT 3
- Shares: describe behaviour of slashes in query terms HOT 2
- Shares: allow configuration of different executors for scanning shares
- Shares: properly define behavior when attempting to add a directory that is already shared
- Shares: load_from_settings should remove directories that are no longer shared, update existing one's
- Users: add less convoluted way to add and remove friends
- Users: Tracking flags need to be removed when disconnected HOT 1
- Investigation usage of SQLite database
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aioslsk.