Git Product home page Git Product logo

Comments (8)

balvinder294 avatar balvinder294 commented on August 26, 2024 1

Hey, thanks Jure, i will check and come back to you

from github-oauth-popup.

balvinder294 avatar balvinder294 commented on August 26, 2024 1

Thanks, i was also changing the redirection URL and now it worked, before I was not getting the code. And thanks for this project.
One more thing, can it be used with other git sites like Gitlab and bitbucket ?

from github-oauth-popup.

JureSotosek avatar JureSotosek commented on August 26, 2024

Just updated the package to 1.2.0 to address this issue. I added babel's polyfill so it does not have to be included in the actual project it is used in. Can you verify this fixes the issue?

from github-oauth-popup.

balvinder294 avatar balvinder294 commented on August 26, 2024

Hey, Jure thanks it is working now, but can you help how to get the code we get from popup , in the component where we call the function and also close the popup.

from github-oauth-popup.

JureSotosek avatar JureSotosek commented on August 26, 2024

Not sure what exactly you mean.

The popup closes automatically when it is redirected to the page where it came from. So, for example, if popup is triggered from "example.com", when it gets redirected back to "example.com", it closes.

If you are running a dev server on, for example, "localhost:3000" you also then have to set the redirect link to "localhost:3000" in the github oauth app settings.

from github-oauth-popup.

JureSotosek avatar JureSotosek commented on August 26, 2024

I am not sure, I'm guessing without some heavy modification that would not be possible since their OAuth API is different.

from github-oauth-popup.

balvinder294 avatar balvinder294 commented on August 26, 2024

Ohk thanks, I will be checking back this project, and if I can contribute any help for this project, pls let me know as I cannot find git authentication packages for angular 2+.

from github-oauth-popup.

JureSotosek avatar JureSotosek commented on August 26, 2024

Hey, if you think there is anything you could add/improved I am always open to discussion and PRs.

from github-oauth-popup.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.