Git Product home page Git Product logo

Comments (10)

kgryte avatar kgryte commented on July 18, 2024

I haven't kept up with work in core, so I'm not sure if the core implementation has feature parity. There was talk some time ago that this extension may need to be refactored so that things like collapsible headings can be implemented on top of core. In which case, some development could still happen on this repo or maybe that could now all happen in core. Others invariably know more than I.

from jupyterlab-toc.

telamonian avatar telamonian commented on July 18, 2024

some development could still happen on this repo

That kind of splitting of issues and codebase is exactly what I want to avoid. The TOC extension included in core is now the canonical one, that's where all new work should go

or maybe that could now all happen in core

yes, please

from jupyterlab-toc.

marthacryan avatar marthacryan commented on July 18, 2024

I support archiving this - as mentioned above, it's better to just direct all changes to the core extension now. Not sure I have the permissions to archive it, but I'll add a PR to add the text to the README about versions / etc.

from jupyterlab-toc.

ellisonbg avatar ellisonbg commented on July 18, 2024

from jupyterlab-toc.

jasongrout avatar jasongrout commented on July 18, 2024

This is saying that there will be no more releases of ToC for jlab 2.x, even backports of things from the core 3.0 extension. Is that okay with everyone? Especially given that we still haven't released 3.0 and 2.x is still the current version.

from jupyterlab-toc.

jasongrout avatar jasongrout commented on July 18, 2024

It makes me a bit nervous to archive something that is still the stable released version, without the next version being released yet

from jupyterlab-toc.

lresende avatar lresende commented on July 18, 2024

How about we clarify the direction we are taking in the README, and wait a little bit for the archive.
Having said that, I don't have access to archive it.

from jupyterlab-toc.

jasongrout avatar jasongrout commented on July 18, 2024

How about we clarify the direction we are taking in the README, and wait a little bit for the archive.

That seems safer to me. If there is a huge security issue that needs a patch in the jlab 2.x plugin, you might still want to do a patch release. I would say archive the repo when the 2.x plugin is no longer supported.

from jupyterlab-toc.

marthacryan avatar marthacryan commented on July 18, 2024

@jasongrout Do you think we should be backporting PR's from the core 3.0 extension? I haven't been doing that for any of my PR's in the main JL repo, but I can do that if you want. Good point that security releases could be necessary though so we should wait until 2.x is no longer supported to archive. I can update the README to explain it correctly

from jupyterlab-toc.

jasongrout avatar jasongrout commented on July 18, 2024

Do you think we should be backporting PR's from the core 3.0 extension?

That's up to the maintainers here to make that decision, of course (i.e., including you :), but my feeling is that just backporting security fixes is perfectly fine.

from jupyterlab-toc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.