Git Product home page Git Product logo

Comments (3)

minrk avatar minrk commented on June 11, 2024

I don't think this is related to #1289 because unlike the Hub, CHP never specifies from internal configuration what ip anyone should connect to.

CHP doesn't use the bind address (which is ~always 0.0.0.0) for this, it uses the Host header so that it should be the same as the connect ip for a properly assembled request. My guess is the upstream proxy is not passing through the Host header. We could try to figure out what the proxied Host was (e.g. X-Forwarded-Host), or we could require that the upstream proxy preserve host headers for this feature.

Can you inspect the headers to see what kubernetes is passing?

If there is an additional upstream proxy, it probably makes more sense for it to do the HTTP->HTTPS redirect, anyway.

from configurable-http-proxy.

clancychilds avatar clancychilds commented on June 11, 2024

I think, IIUC, the problem is less about the host, and more about the port?
Inside the k8s cluster, the HTTPS service is listening on 8443 and the HTTP service on 8000. These are portforwarded on the loadbalancer from 443 and 80 respectively.
When --port 8443 and --redirect-port 8000 are set, then a user trying to connect to :80 is portforwarded to :8000 which is 301'd to :8443, which doesn't work.
It may need an option like --redirect-to 443 which would be used on https://github.com/jupyterhub/configurable-http-proxy/blob/master/bin/configurable-http-proxy#L349 to that port (rather than the listen.port)

from configurable-http-proxy.

minrk avatar minrk commented on June 11, 2024

closed by #187

from configurable-http-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.