Error unpacking large file(>2G) about junrar HOT 10 CLOSED

Can you provide the stack trace?

from junrar.

Can you provide sample code on how you use the library in that case? Are you using a stream or a file?

from junrar.

Can you provide sample code on how you use the library in that case? Are you using a stream or a file?
The source.rar size is 3.25G;

import com.github.junrar.Archive;
import com.github.junrar.rarfile.FileHeader;

import java.io.FileInputStream;
import java.io.FileOutputStream;

/**
 * @author chengpei
 */
public class RarUtil {

    public static void main(String[] args){
        String rarPath = "D:\\test\\source.rar";
        String destinationPath = "D:\\test\\unrar\\";
        try {
            unrar(rarPath,destinationPath);
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

    /**
     * unrar
     * @param rarPath rar file path
     * @param destinationPath unrar file path
     */
    public static void unrar(String rarPath, String destinationPath) throws Exception{
        try (FileInputStream inputStream = new FileInputStream(rarPath);
             final Archive archive = new Archive(inputStream);
             FileOutputStream outputStream = new FileOutputStream(destinationPath)){
            while (true) {
                FileHeader fileHeader = archive.nextFileHeader();
                if (fileHeader == null) {
                    break;
                }
                archive.extractFile(fileHeader, outputStream);
            }
        } catch (Exception e){
            throw e;
        }
    }
}

This is the stack trace:

com.github.junrar.exception.CorruptHeaderException
	at com.github.junrar.Archive.readHeaders(Archive.java:345)
	at com.github.junrar.Archive.setChannel(Archive.java:199)
	at com.github.junrar.Archive.setVolume(Archive.java:811)
	at com.github.junrar.Archive.<init>(Archive.java:149)
	at com.github.junrar.Archive.<init>(Archive.java:178)
	at com.vrv.vap.generator.util.RarUtil.unrar(RarUtil.java:35)
	at com.vrv.vap.generator.util.RarUtil.main(RarUtil.java:21)

from junrar.

A recommendation, if you have a file on disk, it's better to use the methods that take a File instead of an InputStream, this will be more performant

from junrar.

A recommendation, if you have a file on disk, it's better to use the methods that take a File instead of an InputStream, this will be more performant

改用文件之后可以正常解压，但是用FileInputStream的时候会报错，报错的方法是RandomAccessInputStream.readUntil的124行，当文件长度大于int的最大值时，变量length会变成负数。

from junrar.

I can't read Chinese, but i roughly get what you said using Google Translate.

When using a File, junrar uses RandomAccessFile which is part of JDK. There is no such thing for streams, so we have our own implementation of RandomAccessInputStream which does caching in memory. It's less efficient to do caching in memory than to use the RandomAccessFile.

from junrar.

I can't read Chinese, but i roughly get what you said using Google Translate.

When using a File, junrar uses RandomAccessFile which is part of JDK. There is no such thing for streams, so we have our own implementation of RandomAccessInputStream which does caching in memory. It's less efficient to do caching in memory than to use the RandomAccessFile.

When using FileInputStrean, RandomAccessInputStream will be wrong every time, you can debug it use my code, when the 'length' is reach Integer.MAX_VALUE, then the 'length' will be negative,so the thread can not read anything.

from junrar.

i fixed it, thanks for your analysis. But use File instead of InputStream if you can, you will have better perf.

from junrar.

I hope you can fix this in the BUG in next version as soon as possible. Thank you very much!

from junrar.

🎉 This issue has been resolved in version 7.5.4 🎉

The release is available on:

• v7.5.4
• GitHub release

Your semantic-release bot 📦🚀

from junrar.